Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #430 false facts are missing #437

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Fix #430 false facts are missing #437

merged 2 commits into from
Nov 2, 2022

Conversation

zigford
Copy link
Contributor

@zigford zigford commented Nov 2, 2022

SUMMARY

Fix #430 false facts are missing

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_setup

ADDITIONAL INFORMATION

Before

ansible_true_fact: true

After:

ansible_false_fact: false
ansible_true_fact: true

Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, just needs a changelog fragment as documented in https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment.

@zigford
Copy link
Contributor Author

zigford commented Nov 2, 2022

Changes look great, just needs a changelog fragment as documented in https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment.

I've added a fragment. Let me know if I've misinterpreted how it should be setup and I'll tweak accordingly.

@jborean93
Copy link
Collaborator

Looks great, thanks for working on this!

@jborean93 jborean93 merged commit 97e9060 into ansible-collections:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local facts that return false are missing
2 participants