Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_virtualenv treated as defined when defaulted to empty string #161

Closed
konraddzyr opened this issue Mar 27, 2018 · 2 comments
Closed

is_virtualenv treated as defined when defaulted to empty string #161

konraddzyr opened this issue Mar 27, 2018 · 2 comments

Comments

@konraddzyr
Copy link

Hi All!

Playbook tries to run task "Install netaddr dependency on controlling host (virtualenv)" when varaible VIRTUAL_ENV is not set in VM. Then is_virtualenv is defaulted to '' what is treated as defined value. Then task without user arg is invoked and it results in error caused by lack of permissions on VM.
Connected to #129

I'm running role with vagrant 2.0.2 on Win10 against Centos 7 on Virtualbox 5.2.4
@anshulaa
Copy link

Any hacks for this?

@brianshumate
Copy link
Contributor

I am hoping we can just remove the need for installing netaddr to address this.

jpiron pushed a commit to jpiron/ansible-consul that referenced this issue Sep 7, 2018
Fix is_virtualenv undefined condition
60d0b3d 
As is_virtualenv is part of the defaults variables it is always defined.
Instead it should be checked against empty string or None.

Fixes ansible-collections#161
@jpiron jpiron mentioned this issue Sep 7, 2018
Merged
jpiron pushed a commit to jpiron/ansible-consul that referenced this issue Sep 14, 2018
Fix is_virtualenv undefined condition
91efd4c 
As is_virtualenv is part of the defaults variables it is always defined.
Instead it should be checked against empty string or None.

Fixes ansible-collections#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brianshumate @konraddzyr @anshulaa