Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link PR in changelog #665

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Link PR in changelog #665

merged 1 commit into from
Feb 10, 2022

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

Link PR in changelog

@alinabuzachis
Reference PR in the changelog
11fbab0 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis added the backport-3 PR should be backported to the stable-3 branch label Feb 10, 2022
@ansibullbot ansibullbot added community_review owner_pr PR created by owner/maintainer labels Feb 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Feb 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b381554 into ansible-collections:main Feb 10, 2022
@patchback
Copy link

patchback bot commented Feb 10, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/b3815541e2da068bce9a177c713b35d104e632b1/pr-665

Backported as #666

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 10, 2022
@alinabuzachis @patchback
Reference PR in the changelog (#665)
e7c2014 
Link PR in changelog

SUMMARY

Link PR in changelog

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit b381554)
@patchback patchback bot mentioned this pull request Feb 10, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 10, 2022
@patchback
Reference PR in the changelog (#665) (#666)
8ca24ae 
[PR #665/b3815541 backport][stable-3] Link PR in changelog

This is a backport of PR #665 as merged into main (b381554).
SUMMARY

Link PR in changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#665 from tremble/cleanup/cred_…
db06a1c 
…tests

Remove "missing credentials" tests

SUMMARY
AWS Client creation is now done inside a helper module which is more thoroughly tested. Remove the extra tests from aws_api_gateway, ec2_asg, ec2_transit_gateway, lambda_policy, and rds_instance. They bring no significant value but do bump up the login failure count, which can result in the IPs getting temporarily black-listed
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_api_gateway
ec2_asg
ec2_transit_gateway
lambda
lambda_policy
rds_instance
ADDITIONAL INFORMATION
https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/module_utils_ec2/roles/connect_to_aws/tasks/main.yml

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
backport-3 PR should be backported to the stable-3 branch community_review mergeit Merge the PR (SoftwareFactory) owner_pr PR created by owner/maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinabuzachis @tremble @markuman @ansibullbot