Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep 3.1.0 release #664

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Feb 9, 2022

SUMMARY

Prep 3.1.0 release

Run add_docs, generate changelog

@ansibullbot
Copy link

@alinabuzachis This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels Feb 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman
Copy link
Member

Must the docs be generated against stable-3 branch?

@tremble
Copy link
Contributor

tremble commented Feb 10, 2022

Must the docs be generated against stable-3 branch?

Yeah, otherwise the version metadata will be wrong. What we will need to do is "forward-port" the changelog related updates into main.

CHANGELOG.rst Outdated
Deprecated Features
-------------------

- ec2_instance - The default value for ```instance_type``` has been deprecated, in the future release you must set an instance_type or a launch_template".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely link off to the PR. This must have been missed in the original PR, but I think for deprecation PRs it's more important to include a link so people can understand the background.

@alinabuzachis
Copy link
Contributor Author

Yeah, otherwise the version metadata will be wrong. What we will need to do is "forward-port" the changelog related updates into main.

@tremble Not sure how to do that.

@tremble
Copy link
Contributor

tremble commented Feb 10, 2022

Yeah, otherwise the version metadata will be wrong. What we will need to do is "forward-port" the changelog related updates into main.

@tremble Not sure how to do that.

Probably a cherry-pick with some things stripped out.

CHANGELOG.rst Outdated
Comment on lines 15 to 16
- aws_s3 - Add ``validate_bucket_name`` option, to control bucket name validation (https://github.com/ansible-collections/amazon.aws/pull/615).
- aws_s3 - Add `validate_bucket_name` option, to control bucket name validation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the old things are kept here... Try to figure out why.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I think last time I did a hard-reset of the branch before re-running the docs generation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done that.

Run add_docs, generate changelog
@alinabuzachis
Copy link
Contributor Author

Yeah, otherwise the version metadata will be wrong. What we will need to do is "forward-port" the changelog related updates into main.

@tremble Not sure how to do that.

Probably a cherry-pick with some things stripped out.

Ah thanks. The thing that brought me to overthink was that "forward-port" 😂

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Feb 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fe6f5ef into ansible-collections:stable-3 Feb 10, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 10, 2022
Bring changelog changes of amazon.aws 3.1.0 from stable-3

SUMMARY

Since the prep PR has been merged #664, let's bring changelog changes of amazon.aws 3.1.0 from stable-3.

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Formally start the iam deprecation process

SUMMARY
The iam module is based upon the deprecated boto (not boto3/botocore) SDK and its functionality has been replaced by the iam_user, iam_group and iam_role modules.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Formally start the iam deprecation process

SUMMARY
The iam module is based upon the deprecated boto (not boto3/botocore) SDK and its functionality has been replaced by the iam_user, iam_group and iam_role modules.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants