-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep 3.1.0 release #664
Prep 3.1.0 release #664
Conversation
@alinabuzachis This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
Build succeeded.
|
Must the docs be generated against |
Yeah, otherwise the version metadata will be wrong. What we will need to do is "forward-port" the changelog related updates into main. |
CHANGELOG.rst
Outdated
Deprecated Features | ||
------------------- | ||
|
||
- ec2_instance - The default value for ```instance_type``` has been deprecated, in the future release you must set an instance_type or a launch_template". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely link off to the PR. This must have been missed in the original PR, but I think for deprecation PRs it's more important to include a link so people can understand the background.
@tremble Not sure how to do that. |
b14233c
to
0553bb1
Compare
Probably a cherry-pick with some things stripped out. |
CHANGELOG.rst
Outdated
- aws_s3 - Add ``validate_bucket_name`` option, to control bucket name validation (https://github.com/ansible-collections/amazon.aws/pull/615). | ||
- aws_s3 - Add `validate_bucket_name` option, to control bucket name validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the old things are kept here... Try to figure out why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, I think last time I did a hard-reset of the branch before re-running the docs generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done that.
0553bb1
to
3847ea4
Compare
Run add_docs, generate changelog
3847ea4
to
7e08de7
Compare
Ah thanks. The thing that brought me to overthink was that "forward-port" 😂 |
Build succeeded.
|
Build succeeded (gate pipeline).
|
fe6f5ef
into
ansible-collections:stable-3
Bring changelog changes of amazon.aws 3.1.0 from stable-3 SUMMARY Since the prep PR has been merged #664, let's bring changelog changes of amazon.aws 3.1.0 from stable-3. Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]>
Formally start the iam deprecation process SUMMARY The iam module is based upon the deprecated boto (not boto3/botocore) SDK and its functionality has been replaced by the iam_user, iam_group and iam_role modules. ISSUE TYPE Feature Pull Request COMPONENT NAME iam ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: None <None>
Formally start the iam deprecation process SUMMARY The iam module is based upon the deprecated boto (not boto3/botocore) SDK and its functionality has been replaced by the iam_user, iam_group and iam_role modules. ISSUE TYPE Feature Pull Request COMPONENT NAME iam ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: None <None>
SUMMARY
Prep 3.1.0 release
Run add_docs, generate changelog