Add EKS Fargate Profile waiters #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
recheck |
|
recheck |
|
recheck |
|
@tjarra Thank you for taking time to work on this. Can you please reference the PR the waiters are needed for? |
This was referenced Feb 17, 2022
jillr
approved these changes
Feb 22, 2022
|
Thanks @tjarra! |
jatorcasso
pushed a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Mar 1, 2022
Add EKS Fargate Profile waiters SUMMARY Add waiters for eks fargate profile to manage deleted and created states. A PR will be done in community.aws to add a new module to manage the eks_fargate_profile resource that uses these waiters. New module PR: ansible-collections/community.aws#942 ISSUE TYPE Feature Pull Request COMPONENT NAME waiter.py Reviewed-by: Jill R <None>
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Mar 31, 2022
New module aws_eks_fargate_profile SUMMARY (this is a copy of #941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections/amazon.aws#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
patchback bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Mar 31, 2022
New module aws_eks_fargate_profile SUMMARY (this is a copy of #941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections/amazon.aws#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit 719483f)
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New module aws_eks_fargate_profile SUMMARY (this is a copy of ansible-collections#941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New module aws_eks_fargate_profile SUMMARY (this is a copy of ansible-collections#941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add waiters for eks fargate profile to manage deleted and created states.
A PR will be done in community.aws to add a new module to manage the eks_fargate_profile resource that uses these waiters.
New module PR: ansible-collections/community.aws#942
ISSUE TYPE
COMPONENT NAME
waiter.py