Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prefix and/or suffix hostvar coming from AWS #621

Merged

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jan 18, 2022

SUMMARY

Closes #535

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Inventory plugins
aws_ec2
aws_rds

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I'd recommend a slight docs change, but wouldn't block on it unless someone like @jillr / @alinabuzachis thinks we should block on it.

plugins/inventory/aws_ec2.py Outdated Show resolved Hide resolved
@abikouo abikouo added gate and removed gate labels Jan 19, 2022
@abikouo abikouo removed the request for review from jillr January 19, 2022 13:39
@abikouo abikouo added the gate label Jan 19, 2022
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit c3582cf into ansible-collections:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2 and aws_rds inventories: An option to prefix hostvar names to prevent accidental collisions
3 participants