Refactor ec2_eni tagging code #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
felixfontein
reviewed
Oct 4, 2021
Co-authored-by: Alina Buzachis <[email protected]>
alinabuzachis
approved these changes
Oct 6, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 27, 2021
Refactor ec2_eni tagging code SUMMARY Use the shared ec2 tagging code for tagging ENIs. Also fixes the test instability (caused by a race condition with VM states) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eni ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 27, 2021
Refactor ec2_eni tagging code SUMMARY Use the shared ec2 tagging code for tagging ENIs. Also fixes the test instability (caused by a race condition with VM states) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eni ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Dec 2, 2021
Refactor ec2_eni tagging code SUMMARY Use the shared ec2 tagging code for tagging ENIs. Also fixes the test instability (caused by a race condition with VM states) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eni ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tive storage (ansible-collections#522) efs - Add support to specify the number of days to transition to inactive storage SUMMARY Support setting EFS lifecycle policy. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.efs ADDITIONAL INFORMATION This is now possible: - name: Set a lifecycle policy community.aws.efs: state: present name: myTestEFS transition_to_ia: 7 targets: - subnet_id: subnet-7654fdca security_groups: [ "sg-4c5d6f7a" ] - name: Remove a lifecycle policy community.aws.efs: state: present name: myTestEFS transition_to_ia: None targets: - subnet_id: subnet-7654fdca security_groups: [ "sg-4c5d6f7a" ] Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tive storage (ansible-collections#522) efs - Add support to specify the number of days to transition to inactive storage SUMMARY Support setting EFS lifecycle policy. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.efs ADDITIONAL INFORMATION This is now possible: - name: Set a lifecycle policy community.aws.efs: state: present name: myTestEFS transition_to_ia: 7 targets: - subnet_id: subnet-7654fdca security_groups: [ "sg-4c5d6f7a" ] - name: Remove a lifecycle policy community.aws.efs: state: present name: myTestEFS transition_to_ia: None targets: - subnet_id: subnet-7654fdca security_groups: [ "sg-4c5d6f7a" ] Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…tive storage (ansible-collections#522) efs - Add support to specify the number of days to transition to inactive storage SUMMARY Support setting EFS lifecycle policy. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.efs ADDITIONAL INFORMATION This is now possible: - name: Set a lifecycle policy community.aws.efs: state: present name: myTestEFS transition_to_ia: 7 targets: - subnet_id: subnet-7654fdca security_groups: [ "sg-4c5d6f7a" ] - name: Remove a lifecycle policy community.aws.efs: state: present name: myTestEFS transition_to_ia: None targets: - subnet_id: subnet-7654fdca security_groups: [ "sg-4c5d6f7a" ] Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use the shared ec2 tagging code for tagging ENIs.
Also fixes the test instability (caused by a race condition with VM states)
ISSUE TYPE
COMPONENT NAME
ec2_eni
ADDITIONAL INFORMATION