Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework s3_bucket and ec2_instance tests to make sure they have the right botocore available for tests needing recent botocore #496

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 10, 2021

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_bucket
ec2_instance

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage plugins plugin (any type) tests tests labels Sep 10, 2021
@tremble tremble force-pushed the tests/botocore branch 2 times, most recently from 123b221 to 42c77fe Compare September 10, 2021 12:32
…ght botocore available for tests needing recent botocore
abhattacharyaNS1 pushed a commit to abhattacharyaNS1/amazon.aws that referenced this pull request Sep 10, 2021
@tremble
Copy link
Contributor Author

tremble commented Sep 11, 2021

recheck

@tremble tremble added the gate label Sep 14, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble added gate and removed gate labels Sep 14, 2021
@tremble
Copy link
Contributor Author

tremble commented Sep 14, 2021

First attempt at gating failed due to problems with CI itself.

@ansible-zuul ansible-zuul bot merged commit db8bd9a into ansible-collections:main Sep 14, 2021
ansible-zuul bot pushed a commit that referenced this pull request Sep 17, 2021
…404)

Add constraints.txt and requirements.txt for unit/integration tests

SUMMARY
Now that we state that we support specific minimum versions of the AWS SDKs, make sure we base our unit/integration tests against them such that modules need to explicitly test/request newer versions of the SDKs.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration
tests/unit
ADDITIONAL INFORMATION
Once merged into amazon.aws we should merge this into community.aws
Depends-On: #453
Depends-On: #454
Depends-On: #450
Depends-On: #496
See also: ansible/ansible-zuul-jobs#991

Reviewed-by: Jill R <None>
Reviewed-by: None <None>
@tremble tremble deleted the tests/botocore branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ollections#496)

* Test idempotency with adding a route
* tweak changelog to include bugfix link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants