ec2_vol support MultiAttach disk #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
changed the title
ansibullbot
added
community_review
feature
|
@abikouo this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
abikouo
force-pushed
the
ec2_vol_multiattach
branch
from
b96f8e7
to
77a60f1
Compare
ansibullbot
added
community_review
and removed
merge_commit
|
recheck |
|
@abikouo thank you for working on this. Can you please rebase your PR? |
ansibullbot
added
needs_rebase
|
@abikouo this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
abikouo
force-pushed
the
ec2_vol_multiattach
branch
from
00f8c5e
to
82cbb63
Compare
ansibullbot
added
community_review
and removed
merge_commit
|
gate |
markuman
suggested changes
Jun 22, 2021
Co-authored-by: Markus Bergholz <[email protected]>
tremble
requested changes
Jun 23, 2021
| @@ -0,0 +1,3 @@ | |||
| minor_changes: | |||
| - ec2_vol - add parameter ``multi_attach`` to support Multi-Attach on volume creation/update (https://github.com/ansible-collections/amazon.aws/pull/362). | |||
| - ec2_vol_info - return ``attachment_set`` is now a list of attachments with Multi-Attach support on disk. (https://github.com/ansible-collections/amazon.aws/pull/362). | |||
There was a problem hiding this comment.
This is a breaking change and needs to be documented as such. Next release is a major release so I think we can get away with this (? @jillr ?)
tremble
approved these changes
Jun 23, 2021
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ansible-collections#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes ansible-collections#365 ansible-collections#796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of ansible-collections#793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
new parameter
multi_attachto support MultiAttach on disk creation/update#225
ISSUE TYPE
COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION