Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_eni: Fix idempotency when security_groups is specified #337

Merged
merged 5 commits into from
Jul 8, 2021
Merged

ec2_eni: Fix idempotency when security_groups is specified #337

merged 5 commits into from
Jul 8, 2021

Commits on Apr 23, 2021

  1. Fix idempotency when security_groups is specified 

    If `security_groups` attribute is specified - module always returns
`Changed` = `True`.

Example:

```
- amazon.aws.ec2_eni:
    name: my-eni
    security_groups:
      - my-sg
    subnet_id: subnet-123456
```

Will always return `Changed` = `True`.

This PR fixes that.
    @ichekaldin
    ichekaldin committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d84e86f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Minor edit (mostly to retrigger tests)

    @ichekaldin
    ichekaldin committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    550ad26 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. ipaddr filter has been moved ansible.netcommon collection

    @ichekaldin
    ichekaldin committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    5968ca3 View commit details
    Browse the repository at this point in the history

  2. Attempt to explicitly specify ansible.netcommon.ipaddr() instead of j… 

    …ust ipaddr()
    @ichekaldin
    ichekaldin committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    73067dc View commit details
    Browse the repository at this point in the history

  3. Minor edit

    @ichekaldin
    ichekaldin committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    359a554 View commit details
    Browse the repository at this point in the history