[Part #3] Ensures the modules documentation follows the correct formats #2082

alinabuzachis · 2024-05-10T15:25:32Z

SUMMARY

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions · 2024-05-10T15:28:23Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2024-05-10T16:03:09Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3b63a4395cb34df6a5cd86ec0d22bffd

✔️ ansible-galaxy-importer SUCCESS in 5m 16s
✔️ build-ansible-collection SUCCESS in 15m 33s
✔️ ansible-test-splitter SUCCESS in 7m 03s
✔️ integration-amazon.aws-1 SUCCESS in 18m 14s
✔️ integration-amazon.aws-2 SUCCESS in 12m 59s
✔️ integration-amazon.aws-3 SUCCESS in 19m 54s
✔️ integration-amazon.aws-4 SUCCESS in 8m 29s
✔️ integration-amazon.aws-5 SUCCESS in 6m 48s
✔️ integration-amazon.aws-6 SUCCESS in 6m 26s
✔️ integration-amazon.aws-7 SUCCESS in 8m 15s
✔️ integration-amazon.aws-8 SUCCESS in 6m 37s
Skipped 36 jobs

softwarefactory-project-zuul · 2024-05-13T18:22:18Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/42f387a058ec4876b63fbd356f59f22b

✔️ ansible-galaxy-importer SUCCESS in 5m 35s
✔️ build-ansible-collection SUCCESS in 17m 18s
✔️ ansible-test-splitter SUCCESS in 6m 24s
✔️ integration-amazon.aws-1 SUCCESS in 22m 48s
✔️ integration-amazon.aws-2 SUCCESS in 16m 05s
✔️ integration-amazon.aws-3 SUCCESS in 23m 19s
✔️ integration-amazon.aws-4 SUCCESS in 13m 31s
✔️ integration-amazon.aws-5 SUCCESS in 6m 30s
✔️ integration-amazon.aws-6 SUCCESS in 8m 17s
✔️ integration-amazon.aws-7 SUCCESS in 11m 38s
✔️ integration-amazon.aws-8 SUCCESS in 9m 53s
✔️ integration-community.aws-1 SUCCESS in 18m 29s
✔️ integration-community.aws-2 SUCCESS in 6m 48s
Skipped 34 jobs

softwarefactory-project-zuul · 2024-05-23T09:39:55Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/amazon.aws for 2082,8a35e794e70772c9be9d116404d55ee0eb91d12e

softwarefactory-project-zuul · 2024-05-23T09:41:06Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/amazon.aws for 2082,b670c4957db1f5ef5ce1862ea52f92078fb2321c

Signed-off-by: Alina Buzachis <[email protected]>

tremble

Some minor suggestions, not blockers.

plugins/modules/ec2_vpc_endpoint.py

plugins/modules/ec2_vpc_igw_info.py

softwarefactory-project-zuul · 2024-05-23T10:36:13Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eb98fefec15c4db6879602806cfd7b03

✔️ ansible-galaxy-importer SUCCESS in 11m 21s
✔️ build-ansible-collection SUCCESS in 19m 02s
✔️ ansible-test-splitter SUCCESS in 8m 56s
✔️ integration-amazon.aws-1 SUCCESS in 19m 22s
✔️ integration-amazon.aws-2 SUCCESS in 14m 00s
✔️ integration-amazon.aws-3 SUCCESS in 21m 04s
✔️ integration-amazon.aws-4 SUCCESS in 10m 14s
✔️ integration-amazon.aws-5 SUCCESS in 9m 11s
✔️ integration-amazon.aws-6 SUCCESS in 8m 52s
✔️ integration-amazon.aws-7 SUCCESS in 9m 01s
✔️ integration-amazon.aws-8 SUCCESS in 7m 35s
Skipped 36 jobs

Signed-off-by: Alina Buzachis <[email protected]>

plugins/modules/ec2_vpc_net_info.py

plugins/modules/ec2_vpc_route_table_info.py

plugins/modules/ec2_vpc_subnet_info.py

softwarefactory-project-zuul · 2024-05-23T12:36:57Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/93a8d9b2f9144f57b1b45555c80b543e

✔️ ansible-galaxy-importer SUCCESS in 5m 25s
✔️ build-ansible-collection SUCCESS in 18m 42s
✔️ ansible-test-splitter SUCCESS in 8m 08s
✔️ integration-amazon.aws-1 SUCCESS in 19m 38s
❌ integration-amazon.aws-2 RETRY_LIMIT in 1m 42s
✔️ integration-amazon.aws-3 SUCCESS in 18m 51s
✔️ integration-amazon.aws-4 SUCCESS in 9m 05s
✔️ integration-amazon.aws-5 SUCCESS in 6m 27s
✔️ integration-amazon.aws-6 SUCCESS in 7m 49s
✔️ integration-amazon.aws-7 SUCCESS in 8m 07s
✔️ integration-amazon.aws-8 SUCCESS in 6m 09s
Skipped 36 jobs

tremble · 2024-05-23T12:57:26Z

regate

softwarefactory-project-zuul · 2024-05-23T13:34:15Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/20adc7fd3a3d4ef9be9fed197a992698

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 16m 15s
✔️ ansible-test-splitter SUCCESS in 7m 42s
✔️ integration-amazon.aws-1 SUCCESS in 18m 16s
✔️ integration-amazon.aws-2 SUCCESS in 15m 32s
✔️ integration-amazon.aws-3 SUCCESS in 19m 01s
✔️ integration-amazon.aws-4 SUCCESS in 8m 37s
✔️ integration-amazon.aws-5 SUCCESS in 6m 28s
✔️ integration-amazon.aws-6 SUCCESS in 7m 54s
✔️ integration-amazon.aws-7 SUCCESS in 8m 07s
✔️ integration-amazon.aws-8 SUCCESS in 8m 46s
Skipped 36 jobs

…ts (ansible-collections#2082) [Part #3] Ensures the modules documentation follows the correct formats SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell

patchback · 2024-08-27T13:22:37Z

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b47d1cf on top of patchback/backports/stable-8/b47d1cffde53d3576d40d705d003214c6deeb06b/pr-2082

Backporting merged PR #2082 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-8/b47d1cffde53d3576d40d705d003214c6deeb06b/pr-2082 upstream/stable-8

Now, cherry-pick PR [Part #3] Ensures the modules documentation follows the correct formats #2082 contents into that branch:
```
$ git cherry-pick -x b47d1cffde53d3576d40d705d003214c6deeb06b
```
If it'll yell at you with something like fatal: Commit b47d1cffde53d3576d40d705d003214c6deeb06b is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x b47d1cffde53d3576d40d705d003214c6deeb06b
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR [Part #3] Ensures the modules documentation follows the correct formats #2082 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-8/b47d1cffde53d3576d40d705d003214c6deeb06b/pr-2082

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2024-08-27T13:23:04Z

Backport to stable-failed: 💔 cherry-picking failed — target branch does not exist

❌ Failed to find branch stable-failed

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2024-08-27T16:20:37Z

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/b47d1cffde53d3576d40d705d003214c6deeb06b/pr-2082

Backported as #2247

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…ts (#2082) [Part #3] Ensures the modules documentation follows the correct formats SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell (cherry picked from commit b47d1cf)

…ts (#2082) (#2247) This is a backport of PR #2082 as merged into main (b47d1cf). SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell

alinabuzachis force-pushed the docs_update_3 branch from d3e643d to 20c4e99 Compare May 13, 2024 15:43

alinabuzachis added 3 commits May 23, 2024 11:52

Ensures the modules documentation follows the correct formats

386adbd

Signed-off-by: Alina Buzachis <[email protected]>

Update ec2_vol.py

2589472

Update ec2_vpc_igw.py

f093491

alinabuzachis force-pushed the docs_update_3 branch from b670c49 to 3052d51 Compare May 23, 2024 09:53

Update ec2_vpc_endpoint.py

417e0bd

alinabuzachis force-pushed the docs_update_3 branch from 3052d51 to 417e0bd Compare May 23, 2024 09:54

tremble approved these changes May 23, 2024

View reviewed changes

plugins/modules/ec2_vpc_endpoint.py Outdated Show resolved Hide resolved

plugins/modules/ec2_vpc_igw_info.py Outdated Show resolved Hide resolved

plugins/modules/ec2_vpc_igw_info.py Outdated Show resolved Hide resolved

alinabuzachis added 3 commits May 23, 2024 12:36

Apply suggestions

bbf0e3e

Signed-off-by: Alina Buzachis <[email protected]>

Update ec2_vpc_nat_gateway.py

0898e54

Update ec2_vpc_subnet.py

e2444ea

tremble approved these changes May 23, 2024

View reviewed changes

ec2/EC2

37ff58d

tremble added the mergeit Merge the PR (SoftwareFactory) label May 23, 2024

softwarefactory-project-zuul bot merged commit b47d1cf into ansible-collections:main May 23, 2024
36 of 37 checks passed

tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 27, 2024

tremble added the backport_failed Backport failed, needs review label Aug 27, 2024

tremble removed the backport-8 PR should be backported to the stable-8 branch label Aug 27, 2024

tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 27, 2024

patchback bot mentioned this pull request Aug 27, 2024

[PR #2082/b47d1cff backport][stable-8] [Part #3] Ensures the modules documentation follows the correct formats #2247

Merged

tremble removed the backport_failed Backport failed, needs review label Aug 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Part #3] Ensures the modules documentation follows the correct formats #2082

[Part #3] Ensures the modules documentation follows the correct formats #2082

alinabuzachis commented May 10, 2024

github-actions bot commented May 10, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented May 10, 2024

softwarefactory-project-zuul bot commented May 13, 2024

softwarefactory-project-zuul bot commented May 23, 2024

softwarefactory-project-zuul bot commented May 23, 2024

tremble left a comment

softwarefactory-project-zuul bot commented May 23, 2024

softwarefactory-project-zuul bot commented May 23, 2024

tremble commented May 23, 2024

softwarefactory-project-zuul bot commented May 23, 2024

patchback bot commented Aug 27, 2024 •

edited

Loading

patchback bot commented Aug 27, 2024 •

edited

Loading

patchback bot commented Aug 27, 2024 •

edited

Loading

[Part #3] Ensures the modules documentation follows the correct formats #2082

[Part #3] Ensures the modules documentation follows the correct formats #2082

Conversation

alinabuzachis commented May 10, 2024

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented May 10, 2024 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented May 10, 2024

softwarefactory-project-zuul bot commented May 13, 2024

softwarefactory-project-zuul bot commented May 23, 2024

softwarefactory-project-zuul bot commented May 23, 2024

tremble left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented May 23, 2024

softwarefactory-project-zuul bot commented May 23, 2024

tremble commented May 23, 2024

softwarefactory-project-zuul bot commented May 23, 2024

patchback bot commented Aug 27, 2024 • edited Loading

Backport to stable-8: 💔 cherry-picking failed — conflicts found

Backporting merged PR #2082 into main

patchback bot commented Aug 27, 2024 • edited Loading

Backport to stable-failed: 💔 cherry-picking failed — target branch does not exist

patchback bot commented Aug 27, 2024 • edited Loading

Backport to stable-8: 💚 backport PR created

github-actions bot commented May 10, 2024 •

edited

Loading

patchback bot commented Aug 27, 2024 •

edited

Loading

patchback bot commented Aug 27, 2024 •

edited

Loading

patchback bot commented Aug 27, 2024 •

edited

Loading