Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam_managed_policy - add support for path and tagging #1936

Merged
merged 12 commits into from
Jan 3, 2024
Merged

iam_managed_policy - add support for path and tagging #1936

merged 12 commits into from
Jan 3, 2024

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Dec 22, 2023 •
edited
Loading

SUMMARY
  • Fixes minor bug where description was only returned if changes were made.
  • Adds support for setting the path on IAM Managed Policies.
  • Adds support for tagging Managed Policies
ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

iam_managed_policy

ADDITIONAL INFORMATION

@tremble tremble marked this pull request as ready for review December 22, 2023 16:20
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Dec 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e817b44437554f0b93f35eb4044d1840

✔️ ansible-galaxy-importer SUCCESS in 9m 10s
✔️ build-ansible-collection SUCCESS in 15m 06s
✔️ ansible-test-splitter SUCCESS in 5m 49s
✔️ integration-amazon.aws-1 SUCCESS in 14m 37s
✔️ integration-amazon.aws-2 SUCCESS in 6m 30s
✔️ integration-community.aws-1 SUCCESS in 14m 47s
Skipped 41 jobs

@tremble tremble force-pushed the iam/path/managed_policy branch 2 times, most recently from 8b609c3 to 1060e70 Compare December 22, 2023 17:01
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/03792656193e473bafed53697e52953c

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 14m 04s
✔️ ansible-test-splitter SUCCESS in 5m 51s
✔️ integration-amazon.aws-1 SUCCESS in 6m 02s
✔️ integration-amazon.aws-2 SUCCESS in 6m 05s
✔️ integration-community.aws-1 SUCCESS in 6m 00s
Skipped 41 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2b859696bf1b4609ad511fd800ca1b52

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 14m 48s
✔️ ansible-test-splitter SUCCESS in 5m 53s
✔️ integration-amazon.aws-1 SUCCESS in 6m 34s
✔️ integration-amazon.aws-2 SUCCESS in 5m 16s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eed246bad9a0440c81d32d6708a3ff49

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 14m 58s
✔️ ansible-test-splitter SUCCESS in 5m 47s
✔️ integration-amazon.aws-1 SUCCESS in 7m 23s
✔️ integration-amazon.aws-2 SUCCESS in 7m 07s
✔️ integration-community.aws-1 SUCCESS in 11m 19s
Skipped 41 jobs

@tremble tremble changed the title iam_managed_policy - add support for path iam_managed_policy - add support for path and tagging Jan 2, 2024
@tremble tremble requested a review from hakbailey January 2, 2024 09:03
hakbailey
hakbailey approved these changes Jan 2, 2024
View reviewed changes
plugins/modules/iam_managed_policy.py Outdated Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 3, 2024
@tremble
Copy link
Contributor Author

tremble commented Jan 3, 2024

@hakbailey thanks for the review, good catch I'd just kept the original error handling.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/3b625eb89a8f45f6af562ae5e22b7040

❌ ansible-galaxy-importer RETRY_LIMIT in 7m 00s
✔️ build-ansible-collection SUCCESS in 15m 08s
✔️ ansible-test-splitter SUCCESS in 5m 46s
✔️ integration-amazon.aws-1 SUCCESS in 6m 01s
❌ integration-amazon.aws-2 RETRY_LIMIT in 6m 40s
✔️ integration-community.aws-1 SUCCESS in 6m 15s
Skipped 41 jobs

@tremble
Copy link
Contributor Author

tremble commented Jan 3, 2024

regate

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a2a76cb2bf05448dbb9f41c468deb977

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 15m 10s
✔️ ansible-test-splitter SUCCESS in 5m 40s
✔️ integration-amazon.aws-1 SUCCESS in 8m 18s
✔️ integration-amazon.aws-2 SUCCESS in 6m 42s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f95f9eb into ansible-collections:main Jan 3, 2024
36 of 40 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 3, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/f95f9eb47d6a6bd88477ca12364d4547e6f36aae/pr-1936

Backported as #1938

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 3, 2024
@tremble @patchback
iam_managed_policy - add support for path and tagging (#1936)
b71b99b 
iam_managed_policy - add support for path and tagging

SUMMARY

Fixes minor bug where description was only returned if changes were made.
Adds support for setting the path on IAM Managed Policies.
Adds support for tagging Managed Policies

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME
iam_managed_policy
ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Mark Chappell
(cherry picked from commit f95f9eb)
@patchback patchback bot mentioned this pull request Jan 3, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 3, 2024
@patchback
iam_managed_policy - add support for path and tagging (#1936) (#1938)
75a5086 
[PR #1936/f95f9eb4 backport][stable-7] iam_managed_policy - add support for path and tagging

This is a backport of PR #1936 as merged into main (f95f9eb).
SUMMARY

Fixes minor bug where description was only returned if changes were made.
Adds support for setting the path on IAM Managed Policies.
Adds support for tagging Managed Policies

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME
iam_managed_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@tremble tremble deleted the iam/path/managed_policy branch January 12, 2024 09:39
@gravesm gravesm mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakbailey hakbailey hakbailey approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

@abikouo abikouo Awaiting requested review from abikouo

Assignees
No one assigned
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @hakbailey