Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_cluster: add support for ServerlessV2ScalingConfiguration #1839

Merged

Conversation

mandar242
Copy link
Contributor

SUMMARY

Fixes #1476

Add support for ServerlessV2ScalingConfiguration in create_db_cluster and modify_db_cluster

https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ServerlessV2ScalingConfiguration.html
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless-v2.html

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_cluster

ADDITIONAL INFORMATION

Copy link

github-actions bot commented Nov 1, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@mandar242
Copy link
Contributor Author

recheck

This comment was marked as off-topic.

This comment was marked as outdated.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a3d5897ee6bb4e33be9dfad1ef00dcba

✔️ ansible-galaxy-importer SUCCESS in 10m 28s
✔️ build-ansible-collection SUCCESS in 15m 05s
✔️ ansible-test-splitter SUCCESS in 12m 45s
✔️ integration-amazon.aws-1 SUCCESS in 46m 01s
✔️ integration-amazon.aws-2 SUCCESS in 12m 55s
✔️ integration-amazon.aws-3 SUCCESS in 13m 35s
✔️ integration-amazon.aws-4 SUCCESS in 12m 00s
✔️ integration-amazon.aws-5 SUCCESS in 20m 20s
✔️ integration-amazon.aws-6 SUCCESS in 9m 03s
Skipped 38 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e1c143d2b41943a6b84f4dfe4fc3aa5d

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 14m 59s
✔️ ansible-test-splitter SUCCESS in 5m 51s
✔️ integration-amazon.aws-1 SUCCESS in 44m 51s
✔️ integration-amazon.aws-2 SUCCESS in 10m 39s
✔️ integration-amazon.aws-3 SUCCESS in 12m 44s
✔️ integration-amazon.aws-4 SUCCESS in 25m 15s
✔️ integration-amazon.aws-5 SUCCESS in 21m 27s
✔️ integration-amazon.aws-6 SUCCESS in 12m 08s
Skipped 38 jobs

plugins/modules/rds_cluster.py Show resolved Hide resolved
plugins/modules/rds_cluster.py Outdated Show resolved Hide resolved
plugins/modules/rds_cluster.py Outdated Show resolved Hide resolved
plugins/modules/rds_cluster.py Outdated Show resolved Hide resolved
plugins/modules/rds_cluster.py Outdated Show resolved Hide resolved
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b85136c68c324b859ca4613ead2e2019

✔️ ansible-galaxy-importer SUCCESS in 4m 01s
✔️ build-ansible-collection SUCCESS in 16m 51s
✔️ ansible-test-splitter SUCCESS in 7m 17s
✔️ integration-amazon.aws-1 SUCCESS in 41m 43s
✔️ integration-amazon.aws-2 SUCCESS in 10m 19s
✔️ integration-amazon.aws-3 SUCCESS in 11m 30s
✔️ integration-amazon.aws-4 SUCCESS in 13m 18s
✔️ integration-amazon.aws-5 SUCCESS in 17m 13s
✔️ integration-amazon.aws-6 SUCCESS in 8m 41s
Skipped 38 jobs

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything else to be updated in the RETURN block once this option is used?

plugins/modules/rds_cluster.py Outdated Show resolved Hide resolved
@mandar242
Copy link
Contributor Author

Is there anything else to be updated in the RETURN block once this option is used?

added return block for serverless_v2_scaling_configuration

@@ -690,6 +708,14 @@
returned: always
type: str
sample: rds-cluster-demo.cluster-ro-cvlrtwiennww.us-east-1.rds.amazonaws.com
serverless_v2_scaling_configuration:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add version_added: 7.2.0 here too.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/75ff89e5c0a04fa2b50e76c9d1d0a506

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 15m 17s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-amazon.aws-1 SUCCESS in 37m 48s
✔️ integration-amazon.aws-2 SUCCESS in 9m 10s
✔️ integration-amazon.aws-3 SUCCESS in 11m 05s
✔️ integration-amazon.aws-4 SUCCESS in 13m 46s
✔️ integration-amazon.aws-5 SUCCESS in 15m 41s
✔️ integration-amazon.aws-6 SUCCESS in 10m 21s
Skipped 38 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4ba14cbae9184c60b7f3a42250545735

✔️ ansible-galaxy-importer SUCCESS in 9m 32s
✔️ build-ansible-collection SUCCESS in 14m 42s
✔️ ansible-test-splitter SUCCESS in 5m 39s
✔️ integration-amazon.aws-1 SUCCESS in 45m 16s
✔️ integration-amazon.aws-2 SUCCESS in 9m 58s
✔️ integration-amazon.aws-3 SUCCESS in 10m 17s
✔️ integration-amazon.aws-4 SUCCESS in 12m 50s
integration-amazon.aws-5 RETRY_LIMIT in 7m 14s
✔️ integration-amazon.aws-6 SUCCESS in 9m 16s
Skipped 38 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5917e39737554e899cac396c8df0779c

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 14m 23s
✔️ ansible-test-splitter SUCCESS in 6m 02s
✔️ integration-amazon.aws-1 SUCCESS in 43m 23s
✔️ integration-amazon.aws-2 SUCCESS in 8m 46s
✔️ integration-amazon.aws-3 SUCCESS in 11m 15s
✔️ integration-amazon.aws-4 SUCCESS in 13m 30s
✔️ integration-amazon.aws-5 SUCCESS in 17m 17s
✔️ integration-amazon.aws-6 SUCCESS in 9m 27s
Skipped 38 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a00e3fb7a96f4dc5bcc4aca0d72b61dd

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 15m 11s
✔️ ansible-test-splitter SUCCESS in 5m 56s
✔️ integration-amazon.aws-1 SUCCESS in 41m 43s
✔️ integration-amazon.aws-2 SUCCESS in 10m 09s
✔️ integration-amazon.aws-3 SUCCESS in 10m 07s
✔️ integration-amazon.aws-4 SUCCESS in 13m 03s
✔️ integration-amazon.aws-5 SUCCESS in 18m 07s
✔️ integration-amazon.aws-6 SUCCESS in 9m 46s
Skipped 38 jobs

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Dec 15, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b6b8b2a22a2b47a4b4ebe5e804d1802e

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 15m 04s
✔️ ansible-test-splitter SUCCESS in 5m 52s
✔️ integration-amazon.aws-1 SUCCESS in 41m 09s
✔️ integration-amazon.aws-2 SUCCESS in 8m 50s
✔️ integration-amazon.aws-3 SUCCESS in 9m 54s
✔️ integration-amazon.aws-4 SUCCESS in 12m 08s
✔️ integration-amazon.aws-5 SUCCESS in 16m 32s
✔️ integration-amazon.aws-6 SUCCESS in 10m 11s
Skipped 38 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ee3cd0b into ansible-collections:main Dec 15, 2023
40 checks passed
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Jan 10, 2024
Copy link

patchback bot commented Jan 10, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/ee3cd0be860cd57413be9721da83e284835d4a13/pr-1839

Backported as #1943

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 10, 2024
rds_cluster: add support for ServerlessV2ScalingConfiguration

SUMMARY

Fixes #1476
Add support for ServerlessV2ScalingConfiguration in create_db_cluster and modify_db_cluster
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ServerlessV2ScalingConfiguration.html
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless-v2.html

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_cluster
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: GomathiselviS
(cherry picked from commit ee3cd0b)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 10, 2024
…#1943)

[PR #1839/ee3cd0be backport][stable-7] rds_cluster: add support for ServerlessV2ScalingConfiguration

This is a backport of PR #1839 as merged into main (ee3cd0b).
SUMMARY

Fixes #1476
Add support for ServerlessV2ScalingConfiguration in create_db_cluster and modify_db_cluster
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ServerlessV2ScalingConfiguration.html
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless-v2.html

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

rds_cluster
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds_cluster: Add support for Aurora Serverless v2
5 participants