Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1576/b7533c55 backport][stable-6] ec2_instance - fix idempotency issue when attaching ENI to isntance #1579

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 30, 2023

This is a backport of PR #1576 as merged into main (b7533c5).

SUMMARY

closes #1403

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

…1576)

ec2_instance - fix idempotency issue when attaching ENI to isntance

SUMMARY

closes #1403

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_instance

Reviewed-by: Alina Buzachis
(cherry picked from commit b7533c5)
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b63efc2aa1124730860fa76a2085f1e4

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 4m 54s
✔️ integration-amazon.aws-1 SUCCESS in 24m 17s
✔️ integration-amazon.aws-2 SUCCESS in 16m 42s
✔️ integration-amazon.aws-3 SUCCESS in 15m 35s
✔️ integration-amazon.aws-4 SUCCESS in 13m 56s
✔️ integration-amazon.aws-5 SUCCESS in 11m 34s
✔️ integration-amazon.aws-6 SUCCESS in 13m 31s
✔️ integration-amazon.aws-7 SUCCESS in 11m 34s
✔️ integration-amazon.aws-8 SUCCESS in 12m 59s
✔️ integration-amazon.aws-9 SUCCESS in 8m 12s
✔️ integration-amazon.aws-10 SUCCESS in 11m 33s
✔️ integration-amazon.aws-11 SUCCESS in 11m 24s
✔️ integration-amazon.aws-12 SUCCESS in 11m 21s
✔️ integration-amazon.aws-13 SUCCESS in 7m 06s
✔️ integration-amazon.aws-14 SUCCESS in 7m 38s
✔️ integration-amazon.aws-15 SUCCESS in 6m 40s
✔️ integration-amazon.aws-16 SUCCESS in 7m 11s
✔️ integration-amazon.aws-17 SUCCESS in 9m 26s
Skipped 27 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jun 5, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0dc29f1e58194dd7bcf8edf45ca38a64

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 12m 54s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-amazon.aws-1 SUCCESS in 20m 36s
✔️ integration-amazon.aws-2 SUCCESS in 10m 33s
✔️ integration-amazon.aws-3 SUCCESS in 12m 38s
✔️ integration-amazon.aws-4 SUCCESS in 12m 18s
✔️ integration-amazon.aws-5 SUCCESS in 9m 17s
✔️ integration-amazon.aws-6 SUCCESS in 7m 24s
✔️ integration-amazon.aws-7 SUCCESS in 11m 02s
✔️ integration-amazon.aws-8 SUCCESS in 7m 20s
✔️ integration-amazon.aws-9 SUCCESS in 8m 31s
✔️ integration-amazon.aws-10 SUCCESS in 11m 26s
✔️ integration-amazon.aws-11 SUCCESS in 9m 27s
✔️ integration-amazon.aws-12 SUCCESS in 10m 35s
✔️ integration-amazon.aws-13 SUCCESS in 7m 10s
✔️ integration-amazon.aws-14 SUCCESS in 11m 22s
✔️ integration-amazon.aws-15 SUCCESS in 10m 41s
✔️ integration-amazon.aws-16 SUCCESS in 6m 56s
✔️ integration-amazon.aws-17 SUCCESS in 9m 41s
Skipped 27 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 38a8a72 into stable-6 Jun 5, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/b7533c55cbfb63f136d04d3543d7ffb90d0ba7ca/pr-1576 branch June 5, 2023 12:38
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Sep 13, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Sep 13, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 6, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 6, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 20, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix broken ec2_vpc_vgw tests

SUMMARY
The APIs are no longer consistently returning deleted attachments.  Accept both the attachment being listed but marked 'deleted', and not being listed.
Amazon's APIs used to be very slow to update this, making waiting for it a bad idea.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_vgw
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 25, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 26, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 27, 2023
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Aug 29, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Aug 30, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Sep 3, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 19, 2024
Fix broken ec2_vpc_vgw tests

SUMMARY
The APIs are no longer consistently returning deleted attachments.  Accept both the attachment being listed but marked 'deleted', and not being listed.
Amazon's APIs used to be very slow to update this, making waiting for it a bad idea.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_vgw
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cea2ab5
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 19, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 19, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Sep 30, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 7, 2024
Fix non-matching defaults in docs

Depends-On: ansible-collections#1579
SUMMARY
Fix various non-matching default values exposed by ansible/ansible#79267.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various

Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@15568f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants