Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1384/200392e0 backport][stable-5] Allow to disable encryption on cloudtrail #1385

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[PR #1384/200392e0 backport][stable-5] Allow to disable encryption on cloudtrail #1385

merged 1 commit into from
Feb 23, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 23, 2023

This is a backport of PR #1384 as merged into main (200392e).

SUMMARY

Allow to disable encryption on cloudtrail.

Note: Tests are not run in CI because of missing policy.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis @patchback
Allow to disable encryption on cloudtrail (#1384)
aa55782 
Allow to disable encryption on cloudtrail

SUMMARY

Allow to disable encryption on cloudtrail.
Note: Tests are not run in CI because of missing policy.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
(cherry picked from commit 200392e)
@patchback patchback bot mentioned this pull request Feb 23, 2023
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b256110cd0984d04b8e2d481d78b3bb7

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 13s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 59s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 20s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 51s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 23s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 17s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 29s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 49s
✔️ cloud-tox-py3 SUCCESS in 4m 15s
✔️ ansible-test-changelog SUCCESS in 4m 11s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 5m 12s
Skipped 43 jobs

@github-actions
Copy link

github-actions bot commented Feb 23, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 23, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/12f98e1bd4cd4639b847c36b6255a1ec

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 4m 31s
✔️ integration-amazon.aws-1 SUCCESS in 5m 12s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 26a00fc into stable-5 Feb 23, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/200392e03f1402eee5ba714df5aa491f24b8a521/pr-1384 branch February 23, 2023 11:22
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
s3_sync - fix when running in FIPS mode (ansible-collections#1385)
8308539 
s3_sync - fix when running in FIPS mode

SUMMARY
fixes: ansible-collections#757
pass usedforsecurity=False (the MD5 sum isn't used as a cryptographic hash) and attempt to handle FIPS errors more gracefully.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_sync
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
s3_sync - fix when running in FIPS mode (ansible-collections#1385)
8cc4910 
s3_sync - fix when running in FIPS mode

SUMMARY
fixes: ansible-collections#757
pass usedforsecurity=False (the MD5 sum isn't used as a cryptographic hash) and attempt to handle FIPS errors more gracefully.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_sync
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
s3_sync - fix when running in FIPS mode (ansible-collections#1385)
e523866 
s3_sync - fix when running in FIPS mode

SUMMARY
fixes: ansible-collections#757
pass usedforsecurity=False (the MD5 sum isn't used as a cryptographic hash) and attempt to handle FIPS errors more gracefully.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_sync
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @alinabuzachis