Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1288/7e14dcf0 backport][stable-5] ec2_key/tests: add unit-tests #1380

Merged
merged 1 commit into from
Feb 21, 2023
Merged

[PR #1288/7e14dcf0 backport][stable-5] ec2_key/tests: add unit-tests #1380

merged 1 commit into from
Feb 21, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 21, 2023

This is a backport of PR #1288 as merged into main (7e14dcf).

SUMMARY
  • Add the unit-test coverage of the ec2_key module.
  • Refactor the module to reduce complexity and allow unit testing.
COMPONENT NAME

ec2_key

Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html

@mandar242 @patchback
ec2_key/tests: add unit-tests (#1288)
9283c3d 
ec2_key/tests: add unit-tests

SUMMARY

Add the unit-test coverage of the ec2_key module.
Refactor the module to reduce complexity and allow unit testing.

COMPONENT NAME

ec2_key
Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html

Reviewed-by: Mark Chappell <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 7e14dcf)
@patchback patchback bot mentioned this pull request Feb 21, 2023
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ba9ecee9a7334490a642c4cf780cdb12

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 13m 02s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 59s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 14s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 05s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 29s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 21s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 20s
✔️ cloud-tox-py3 SUCCESS in 4m 35s
✔️ ansible-test-changelog SUCCESS in 4m 30s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-amazon.aws-1 SUCCESS in 7m 21s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 21, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c7307d1370714ae88b8b208bff609ccf

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 12m 54s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 7m 00s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3259187 into stable-5 Feb 21, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/7e14dcf02e1ac1be6f556af30c2dabc9f77bf2de/pr-1288 branch February 21, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @mandar242