Add full path to the awx_ec2 inv example #1378
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
@thenets Thank you for fixing examples. Can you also please add a changelog fragment with a trivial entry for this change?https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment
|
@alinabuzachis I added the fragment :) I also made a small change in the description. I think it removes confusion. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 51s |
tremble
force-pushed
the
thenets/inventory-ec2-examples-patch
branch
from
1d2a54c
to
0ff7516
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 03s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1388 🤖 @patchback |
Add full path to the awx_ec2 inv example SUMMARY The current example does not work, since it uses the default namespace and collection names. This fixes the problem and allows anyone who installs the collection to use it outside of the collection scope. ISSUE TYPE Docs Pull Request COMPONENT NAME inventory: aws_ec2 Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell (cherry picked from commit 83d68c1)
[PR #1378/83d68c16 backport][stable-5] Add full path to the awx_ec2 inv example This is a backport of PR #1378 as merged into main (83d68c1). SUMMARY The current example does not work, since it uses the default namespace and collection names. This fixes the problem and allows anyone who installs the collection to use it outside of the collection scope. ISSUE TYPE Docs Pull Request COMPONENT NAME inventory: aws_ec2 Reviewed-by: Mark Chappell
…ctions#1379) route53: Restore support for zero weighted DNS records SUMMARY In ansible-collections#1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes ansible-collections#1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9195021
…ctions#1379) route53: Restore support for zero weighted DNS records SUMMARY In ansible-collections#1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes ansible-collections#1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None>
…ctions#1379) route53: Restore support for zero weighted DNS records SUMMARY In ansible-collections#1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes ansible-collections#1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None>
…ctions#1379) route53: Restore support for zero weighted DNS records SUMMARY In ansible-collections#1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes ansible-collections#1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None>
SUMMARY
The current example does not work, since it uses the default
namespaceandcollectionnames.This fixes the problem and allows anyone who installs the collection to use it outside of the collection scope.
ISSUE TYPE
COMPONENT NAME
aws_ec2