-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor inventory plugin connection handling #1271
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
minor_changes: | ||
- amazon.aws inventory plugins - additional refactorization of inventory plugin connection handling (https://github.com/ansible-collections/amazon.aws/pull/1271). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# -*- coding: utf-8 -*- | ||
# Copyright: (c) 2015, Ansible, Inc | ||
tremble marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
|
||
|
||
class ModuleDocFragment: | ||
# Note: If you're updating MODULES, PLUGINS probably needs updating too. | ||
|
||
# Formatted for Modules | ||
# - modules don't support 'env' | ||
MODULES = r""" | ||
options: {} | ||
""" | ||
|
||
# Formatted for non-module plugins | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it worth adding a note in the README about this doc_fragment? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The scope is currently limited to inventory plugins, so I wasn't going to add one just yet. |
||
# - modules don't support 'env' | ||
PLUGINS = r""" | ||
options: | ||
assume_role_arn: | ||
description: | ||
- The ARN of the IAM role to assume to perform the lookup. | ||
- You should still provide AWS credentials with enough privilege to perform the AssumeRole action. | ||
aliases: ["iam_role_arn"] | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be 2015 or 2022?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022, good catch :)