Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump main to 6.0.0-dev0 #1108

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 5, 2022

SUMMARY

Bump galaxy.yml version to 6.0.0-dev0 so we can start landing breaking changes

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

galaxy.yml

ADDITIONAL INFORMATION

(still draft because I expect deprecation related CI failures)

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage small_patch Hopefully easy to review labels Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

markuman pushed a commit to markuman/amazon.aws that referenced this pull request Oct 5, 2022
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY

When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".

Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.

Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.

Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@0bde6bb
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble added this to the 6.0.0 milestone Oct 5, 2022
@ansibullbot ansibullbot added the tests tests label Oct 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 5m 24s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 32s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 43s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 39s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 22s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 50s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 51s
✔️ cloud-tox-py3 SUCCESS in 2m 53s

@tremble tremble marked this pull request as ready for review October 5, 2022 09:28
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 11s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 24s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 50s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 31s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 07s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 03s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 42s
✔️ cloud-tox-py3 SUCCESS in 2m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 35febb1 into ansible-collections:main Oct 5, 2022
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Oct 5, 2022
@tremble tremble deleted the branching/stable-5/main-to-next branch October 21, 2022 07:31
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants