Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ansible Core < 2.11 #1087

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 28, 2022

SUMMARY

We only perform integration tests against milestone. And we only perform sanity tests against 2.12+. Ansible Core 2.11 goes out of support in November

Trying to maintain support for Ansible 2.9 is only going to get more painful as time goes on, as demonstrated by #1083.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

meta/runtime.yml

ADDITIONAL INFORMATION

Dropping support for 2.9/2.10 puts us in line with Ansible Core, community.general and community.network.

Additionally:

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage labels Sep 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 22s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 47s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 36s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 43s

@jillr
Copy link
Collaborator

jillr commented Sep 28, 2022

I'm checking with Red Hat Product/Downstream on this so we don't surprise them, please hold off on merging until we have confirmation. (I'm totally in favor of this PR otherwise)

Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the supported-EE info and we can drop ansible-core 2.9 support for 5.0.0.

@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Sep 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 5m 28s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 42s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 39s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 26s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 58s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b330814 into ansible-collections:main Sep 29, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Sep 30, 2022
Drop support for Ansible Core < 2.11

SUMMARY
Following up on ansible-collections/amazon.aws#1087
We only perform integration tests against milestone.  And we only perform sanity tests against 2.12+.  Ansible Core  2.11 goes out of support in November
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
meta/runtime.yml
ADDITIONAL INFORMATION
We already dropped support in amazon.aws
Additionally:

AAP 1.2 (based on 2.9) is in "Maintenance support 2" bugs and security fixes only (https://access.redhat.com/support/policy/updates/ansible-automation-platform), which we can support by backporting fixes if necessary
Later versions of AAP support ee-2.9, however ee-2.9 is only supported for "the Ansible Core RPMs" which would mean backports
Ansible Tower is in "Maintenance support 2" bugs and security fixes only (https://access.redhat.com/support/policy/updates/ansible-tower), with support ending in November which we can support by backporting fixes if necessary.
Ansible Engine 2.9 support has ended already (https://access.redhat.com/support/policy/updates/ansible-engine)

Reviewed-by: Gonéri Le Bouder <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 30, 2022
Revert "Work around for #1083 (#1086)"

This reverts commit e0aeafd.
SUMMARY
Following #1087 we no longer need the workaround for #1083.
The work around has been backported to stable-4, which still announces support for Ansible 2.9, however we've now dropped support for 2.9 so don't need this in main/5.0.0
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/cloud.py
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
@tremble tremble mentioned this pull request Oct 6, 2022
1 task
@tremble tremble deleted the deprecate/ansible-2.10 branch October 21, 2022 07:33
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…e now support botocore 1.20 (ansible-collections#1087)

aws_s3_bucket_info - remove custom botocore environment from test

SUMMARY
We now support botocore 1.20, there's no reason to run the tests in a custom environment
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_s3_bucket_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants