Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_route_table should support IPv6 routes #768

Open
1 task done
vonschultz opened this issue Apr 5, 2022 · 6 comments
Open
1 task done

ec2_vpc_route_table should support IPv6 routes #768

vonschultz opened this issue Apr 5, 2022 · 6 comments
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)

Comments

@vonschultz
Copy link

Summary

When trying to add e.g. the default route for IPv6, ::/0, it complains that's not a valid CIDR. When IPv6 routes are already in place, it produces warnings saying

[WARNING]: Skipping purging route {'DestinationIpv6CidrBlock': '::/0', 'GatewayId': 'igw-0cf0f83e528bb6fe2', 'Origin': 'CreateRoute', 'State': 'active'} because it has no destination cidr block. To remove VPC endpoints from route tables use the ec2_vpc_endpoint module.

community.aws.ec2_vpc_route_table should support IPv6 routes, and gracefully handle any IPv6 routes that are already there.

Issue Type

Feature Idea

Component Name

ec2_vpc_route_table

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request needs_triage labels Apr 5, 2022
@tremble tremble transferred this issue from ansible-collections/community.aws Apr 5, 2022
@tremble
Copy link
Contributor

tremble commented Apr 5, 2022

Hi @vonschultz,

Thanks for taking the time to raise this issue. IPv6 support was added by #601 and should be available with release 3.1.0 of amazon.aws.

@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added module module plugins plugin (any type) and removed needs_triage labels Apr 5, 2022
@vonschultz
Copy link
Author

Ah, nice!

@vonschultz
Copy link
Author

I've now upgraded to amazon.aws release 5.2.0, and the warning is still produced, though it no longer refers to ::/0. The warning I get is

[WARNING]: Skipping purging route {'DestinationIpv6CidrBlock': '2a05:d016:e04:a400::/56', 'GatewayId': 'local', 'Origin': 'CreateRouteTable', 'State': 'active'} because it has no destination cidr block. To remove VPC endpoints from route tables use the ec2_vpc_endpoint module.

I see the corresponding code in main, https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_vpc_route_table.py, function ensure_routes(), the if purge_routes branch.

I'm fine with skipping purging this route, as the GatewayId is local and the DestinationIpv6CidrBlock is the CIDR block of the VPC itself, but the warning is strange, since there is a destination CIDR block, and this is entirely unrelated to VPC endpoints.

@vonschultz vonschultz reopened this Feb 6, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
elb_instance - initial integration tests

SUMMARY
Rewrite elb_instance (ec2_elb) for boto3
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_instance
ADDITIONAL INFORMATION
fixes: ansible-collections#384

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
elb_instance - initial integration tests

SUMMARY
Rewrite elb_instance (ec2_elb) for boto3
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_instance
ADDITIONAL INFORMATION
fixes: ansible-collections#384

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
elb_instance - initial integration tests

SUMMARY
Rewrite elb_instance (ec2_elb) for boto3
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_instance
ADDITIONAL INFORMATION
fixes: ansible-collections#384

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Development

No branches or pull requests

3 participants