Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] aws_ec2 (dynamic inventory) use "aws ssm get-inventory" info also #704

Closed
1 task done
Hokwang opened this issue Mar 9, 2022 · 5 comments · Fixed by #1369
Closed
1 task done

[FR] aws_ec2 (dynamic inventory) use "aws ssm get-inventory" info also #704

Hokwang opened this issue Mar 9, 2022 · 5 comments · Fixed by #1369
Assignees
@abikouo
Labels
feature This issue/PR relates to a feature request inventory inventory plugin jira plugins plugin (any type) WIP Work in progress

Comments

@Hokwang
Copy link

Hokwang commented Mar 9, 2022

Summary

Hi,

I think aws_ec2 plugin use ec2 metadata only,
but user who already set up ssm inventroy can use/get ssm inventroy info, too.

When I was searching aws_ec2 plugin,
there's no way to get OS (distro) info,
and ansible_distribution can not use.

so I request the way to get ssm inventory or use directly in aws_ec2 plugin.

Thanks,

Issue Type

Feature Idea

Component Name

aws_ec2

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  inventory

  inventory plugin

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Mar 9, 2022

    

  



    

    

      
    

    


      

          @alinabuzachis
alinabuzachis




            added
      

  needs_verified

  Some one might want to take a look at this and reproduce it to confirm

      

  jira


    and removed
      

  needs_triage


  labels


      Mar 15, 2022

    

  



    

    

      
    

    


      

          @abikouo
abikouo




              self-assigned this


      Feb 14, 2023

    

  



    

    

      
    

    


      

          @abikouo
abikouo




            added
      

  WIP

  Work in progress

    and removed
      

  needs_verified

  Some one might want to take a look at this and reproduce it to confirm

  labels


      Feb 15, 2023

    

  



  

  

    
  


  

      

    @abikouo
abikouo



    mentioned this issue
    
      Feb 15, 2023
    





  


  

      
   Merged

  







  









      

  
      



  

  @abikouo





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
            abikouo
  

      

      

      commented


        Feb 16, 2023


      
    


  





      


        


  
    

      
          
@Hokwang #1369 has introduced a new feature allowing you to add ssm inventory information into host vars, could you please give it a try and see if this matches your expectation?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @Hokwang





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  Author


  


  

    

      

      
            Hokwang
  

      

      

      commented


        Feb 16, 2023


      
    


  





      


        


  
    

      
          
@abikouo OMG!! I will test soon and tell you. thank you!

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Mar 7, 2023
    
    

      


  

    

      


  

      
        @abikouo
  





      

        
          inventory aws_ec2 - add ssm_inventory inventory into hostvars (#1369)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          5aa0e8a
        
      

    

  

    

      
inventory aws_ec2 - add ssm_inventory inventory into hostvars

SUMMARY

using use_ssm_inventory users can populate hostvars with Amazon SSM inventory for configured instances
closes #704

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_ec2 inventory

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell

    




    

  









      

  
      



  

  @Hokwang





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  Author


  


  

    

      

      
            Hokwang
  

      

      

      commented


        Aug 31, 2023


      
    


  





      


        


  
    

      
          
@abikouo So sorry for late, now it merged but, I guarantee this works!

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @vijayreddiar





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

  





      


        


  
    

      
          
The option use_ssm_inventory limits to use only if the number of instances in the syncing account is less than the allowed limit of instances for SSM send_command.

The issue is highlighted in #1713.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    
















  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
    @abikouo
  
    abikouo
    

      








      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    inventory

  inventory plugin
  

    jira

  

    plugins

  plugin (any type)
  

    WIP

  Work in progress








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      inventory aws_ec2 - add ssm_inventory inventory into hostvars

    
      abikouo/amazon.aws
    





    
  




        
      

    

  
      

  

    

      5 participants
    

    

        
          @Hokwang 
        
          @alinabuzachis 
        
          @vijayreddiar 
        
          @ansibullbot 
        
          @abikouo