Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement instance metadata tags support #684

Closed
1 task done
charltonstanley opened this issue Feb 17, 2022 · 4 comments · Fixed by #1186
Closed
1 task done

Implement instance metadata tags support #684

charltonstanley opened this issue Feb 17, 2022 · 4 comments · Fixed by #1186
Assignees
@mandar242
Labels
feature This issue/PR relates to a feature request jira module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@charltonstanley
Copy link

charltonstanley commented Feb 17, 2022 •
edited
Loading

Summary

I would to enable instance metadata tags using ec2_instance. Additionally I'd like to be able to query those tags using ec2_metadata_facts

Issue Type

Feature Idea

Component Name

ec2_instance, ec2_metadata_facts

Additional Information

This feature will help me to enable the ability to query instance metadata tags, as well as actually query instance metadata tags. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#work-with-tags-in-IMDS

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @roadmapper @s-hertel @silviud @tremble
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Feb 17, 2022
@alinabuzachis
Copy link
Contributor

@charltonstanley Thank you for this feature idea. Would you be willing to implement it and open a pull request?

@alinabuzachis alinabuzachis added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Feb 17, 2022
@charltonstanley
Copy link
Author

charltonstanley commented Feb 17, 2022 •
edited
Loading

@alinabuzachis I would if I knew a lick of python, but I don't. I'm not afraid to learn, but my commits might would lack sufficient sophistication to be worthy of inclusion in your code base. 😄

@mandar242 mandar242 self-assigned this Oct 20, 2022
@mandar242 mandar242 mentioned this issue Oct 20, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Oct 27, 2022
@mandar242
ec2_metadata_facts: Add support to query instance tags in metadata (#…
91c0eac 
…1186)

ec2_metadata_facts: Add support to query instance tags in metadata

SUMMARY

Fixes #684
Added support to be able to query instance tags using ec2_metadata_facts.
This PR adds a field in returned ansible_facts named  ansible_ec2_instance_tags_keys.
Sample
"ansible_ec2_instance_tags_keys": [
        "Name",
        "snake_case_key"
],


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_metadata_facts
ADDITIONAL INFORMATION



Support to enable instance metadata tags already exists in amazon.aws.ec2_instance

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this issue Apr 27, 2023
@mandar242 @alinabuzachis
ec2_metadata_facts: Add support to query instance tags in metadata (a…
15bc479 
…nsible-collections#1186)

ec2_metadata_facts: Add support to query instance tags in metadata

SUMMARY

Fixes ansible-collections#684
Added support to be able to query instance tags using ec2_metadata_facts.
This PR adds a field in returned ansible_facts named  ansible_ec2_instance_tags_keys.
Sample
"ansible_ec2_instance_tags_keys": [
        "Name",
        "snake_case_key"
],


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_metadata_facts
ADDITIONAL INFORMATION



Support to enable instance metadata tags already exists in amazon.aws.ec2_instance

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
@alinabuzachis alinabuzachis mentioned this issue Apr 27, 2023
Merged
tremble pushed a commit to alinabuzachis/amazon.aws that referenced this issue May 3, 2023
@mandar242 @tremble
ec2_metadata_facts: Add support to query instance tags in metadata (a…
aa960c6 
…nsible-collections#1186)

ec2_metadata_facts: Add support to query instance tags in metadata

SUMMARY

Fixes ansible-collections#684
Added support to be able to query instance tags using ec2_metadata_facts.
This PR adds a field in returned ansible_facts named  ansible_ec2_instance_tags_keys.
Sample
"ansible_ec2_instance_tags_keys": [
        "Name",
        "snake_case_key"
],


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_metadata_facts
ADDITIONAL INFORMATION



Support to enable instance metadata tags already exists in amazon.aws.ec2_instance

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot pushed a commit that referenced this issue May 3, 2023
@alinabuzachis
[manual backport stable-5] ec2_metadata_facts: Add support to query i…
4178e9a 
…nstance tags in metadata (#1186) (#1488)

[manual backport stable-5] ec2_metadata_facts: Add support to query instance tags in metadata (#1186)

ec2_metadata_facts: Add support to query instance tags in metadata
SUMMARY
Fixes #684
Added support to be able to query instance tags using ec2_metadata_facts. This PR adds a field in returned ansible_facts named  ansible_ec2_instance_tags_keys. Sample
"ansible_ec2_instance_tags_keys": [
"Name",
"snake_case_key"
],
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ec2_metadata_facts
ADDITIONAL INFORMATION
Support to enable instance metadata tags already exists in amazon.aws.ec2_instance
Reviewed-by: Mike Graves [email protected]
Reviewed-by: Mandar Kulkarni [email protected]
Reviewed-by: Gonéri Le Bouder [email protected]
Reviewed-by: Alina Buzachis 
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mandar242 mandar242

Labels
feature This issue/PR relates to a feature request jira module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec2_metadata_facts: Add support to query instance tags in metadata mandar242/amazon.aws
4 participants
@charltonstanley @mandar242 @alinabuzachis @ansibullbot