-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDS - rds_instance - performance_insights_kms_key_id #2217
Comments
I looked in CloudTrail on the CreateDBInstance instance and I found out that AWS does not see Ansible sending a different Actually in the event record in "requestParameters" I do not have at all "performanceInsightsKMSKeyId". I do see "kmsKeyId" set to the same key. In the "responseElements" I can see the "kmsKeyId" applied correctly and I also can see the wrong
which is actually the default "aws/rds". |
I suspect that the issue is with capitalization of parameters:
Note that in the second KMS is all caps. I have tried to create an instance via AWS console and it works ok - I get the custom key in performance insights. |
I'm willing to debug this if anyone can hint me on how to get started. |
I just tried w/ the above and it creates the DB w/ correct keys. |
I might have a confirmation that it is an issue with capitalization of parameters. In line: amazon.aws/plugins/module_utils/rds.py Line 580 in b63f26d
I added KMS:
But this time the DB instance was created w/ the correct key for performance-insights but w/ the wrong key for kms_key_id (it used the default "aws/rds"). |
…lections#2219) SUMMARY performance_insights_kms_key_id parameter has a variation in AWS snake case Fixes ansible-collections#2217 ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance - parameter: performance_insights_kms_key_id ADDITIONAL INFORMATION I have successfully created an rds_instance instance w/ correct custom performance_insights_kms_key_id (not the default: "aws/rds") Reviewed-by: Mark Chappell Reviewed-by: Gabriel PREDA Reviewed-by: Alina Buzachis
…lections#2219) SUMMARY performance_insights_kms_key_id parameter has a variation in AWS snake case Fixes ansible-collections#2217 ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance - parameter: performance_insights_kms_key_id ADDITIONAL INFORMATION I have successfully created an rds_instance instance w/ correct custom performance_insights_kms_key_id (not the default: "aws/rds") Reviewed-by: Mark Chappell Reviewed-by: Gabriel PREDA Reviewed-by: Alina Buzachis
This is a manual backport of PR #2219 as merged into main (1f65ad9). SUMMARY performance_insights_kms_key_id parameter has a variation in AWS snake case Fixes #2217 ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance - parameter: performance_insights_kms_key_id ADDITIONAL INFORMATION I have successfully created an rds_instance instance w/ correct custom performance_insights_kms_key_id (not the default: "aws/rds") Reviewed-by: Mark Chappell Reviewed-by: Gabriel PREDA Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <[email protected]>
Summary
When creating a new rds_instance with a custom "performance_insights_kms_key_id" (not the default one "aws/rds") the KMS key is not applied but the default one is.
Issue Type
Bug Report
Component Name
rds_instance
Ansible Version
Collection Versions
AWS SDK versions
Configuration
OS / Environment
Fedora release 40 (Forty)
Steps to Reproduce
Expected Results
I expect to see the key declared not the default "aws/rds"
Actual Results
in response we have:
"performance_insights_kms_key_id": "arn:aws:kms:eu-west-1:565656565656:key/4063-870a-6da5c69cedff-6f2d4e3e-0635",
Code of Conduct
The text was updated successfully, but these errors were encountered: