route53_health_check - Name tag lost on 2nd deploy #1188

anjo-swe · 2022-10-20T19:38:09Z

Summary

When updating a Route53 health check the Name tag is removed when using health_check_name: my-health-check

Tag is initially added by

amazon.aws/plugins/modules/route53_health_check.py

Line 624 in f9751fa

tags['Name'] = health_check_name

Issue Type

Bug Report

Component Name

route53_health_check

Ansible Version

$ ansible --version

ansible [core 2.12.2]
  config file = /Users/<USER>/Source/dataintelligence-ansible/ansible.cfg
  configured module search path = ['/Users/<USER>/Source/dataintelligence-ansible/library']
  ansible python module location = /Users/<USER>/Source/dataintelligence-ansible/.runtime/.pyvenv/lib/python3.9/site-packages/ansible
  ansible collection location = /Users/<USER>/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/<USER>/Source/dataintelligence-ansible/.runtime/.pyvenv/bin/ansible
  python version = 3.9.8 (main, Nov 18 2021, 16:08:04) [Clang 12.0.5 (clang-1205.0.22.9)]
  jinja version = 2.11.3
  libyaml = True

Collection Versions

Manually added https://github.com/ansible-collections/amazon.aws/blob/5.0.2/plugins/modules/route53_health_check.py to my local Ansible

AWS SDK versions

$ pip show boto boto3 botocore

Name: boto
Version: 2.49.0
Summary: Amazon Web Services Library
Home-page: https://github.com/boto/boto/
Author: Mitch Garnaat
Author-email: [email protected]
License: MIT
Location: /Users/<USER>/Source/dataintelligence-ansible/.runtime/.pyvenv/lib/python3.9/site-packages
Requires:
Required-by:
---
Name: boto3
Version: 1.20.48
Summary: The AWS SDK for Python
Home-page: https://github.com/boto/boto3
Author: Amazon Web Services
Author-email:
License: Apache License 2.0
Location: /Users/<USER>/Source/dataintelligence-ansible/.runtime/.pyvenv/lib/python3.9/site-packages
Requires: botocore, jmespath, s3transfer
Required-by: aws-sam-cli, aws-sam-translator, serverlessrepo
---
Name: botocore
Version: 1.23.48
Summary: Low-level, data-driven core of boto 3.
Home-page: https://github.com/boto/botocore
Author: Amazon Web Services
Author-email:
License: Apache License 2.0
Location: /Users/<USER>/Source/dataintelligence-ansible/.runtime/.pyvenv/lib/python3.9/site-packages
Requires: jmespath, python-dateutil, urllib3
Required-by: awscli, boto3, s3transfer

Configuration

$ ansible-config dump --only-changed

OS / Environment

macOS 11.6

Steps to Reproduce

Run the following playbook twice

---
- hosts: localhost
  tasks:
    - name: Create a health-check
      route53_health_check:
        health_check_name: my-health-check
        use_unique_names: true
        fqdn: ***
        type: HTTPS
        resource_path: /
        request_interval: 30
        failure_threshold: 3
        tags:
          Service: my-service
          Owner: some-owner
          Lifecycle: dev
      register: my_health_check

Expected Results

Name tag added during first run and never removed

Actual Results

First run: Health check created, Name tag added

changed: [localhost] => changed=true
  health_check:
    action: create
    caller_reference: ***
    health_check_config:
      disabled: false
      enable_sni: true
      failure_threshold: 3
      fully_qualified_domain_name: ***
      inverted: false
      measure_latency: false
      port: 443
      request_interval: 30
      resource_path: /
      type: HTTPS
    health_check_version: 1
    id: ***
    tags:
      Lifecycle: dev
      Name: my-health-check
      Owner: some-owner
      Service: my-service

Second run: Health check marked as changed (expected noop [ok]), Name tag removed (not expected)

changed: [localhost] => changed=true
  health_check:
    action: null
    caller_reference: ***
    health_check_config:
      disabled: false
      enable_sni: true
      failure_threshold: 3
      fully_qualified_domain_name: ***
      inverted: false
      measure_latency: false
      port: 443
      request_interval: 30
      resource_path: /
      type: HTTPS
    health_check_version: 1
    id: ***
    tags:
      Lifecycle: dev
      Owner: some-owner
      Service: my-service

Code of Conduct

I agree to follow the Ansible Code of Conduct

The text was updated successfully, but these errors were encountered:

ansibullbot · 2022-10-20T20:10:37Z

Files identified in the description:

[plugins/modules/route53_health_check.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/route53_health_check.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot · 2022-10-20T20:10:38Z

cc @jillr @s-hertel @tremble @zimbatm
click here for bot help

mandar242 · 2022-11-08T05:41:00Z

@anjo-swe thank you for reporting this issue!
I've opened a PR which would likely fix this. #1253
If possible, it would be great if you can test the patch with your current issue and let me know if that solved it.
Thanks!

…1253) route53_health_check: Fix "Name" tag key removal idempotentcy issue SUMMARY Depends-On: #1280 Fixes #1188 When using health_check_name as unique identifier (setting use_unique_names: True and providing a health_check_name) and health_check tags are set, Current logic for adding name to a health_check causes an issue when rerunning the create/update task. While ideally it should be idempotent, it removes the 'Name' tag (used for health_check_name) causing removal of health check name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION To test, run the following sample playbook task twice Expected output: Health check name should not disapper (i.e. 'Name' tag should not get removed on rerun) --- - hosts: localhost gather_facts: False tasks: - name: Create a health-check amazon.aws.route53_health_check: health_check_name: my-test-hc use_unique_names: true fqdn: my-test-xyz.com type: HTTPS resource_path: / request_interval: 30 failure_threshold: 3 tags: Service: my-service Owner: my-test-xyz Lifecycle: dev Reviewed-by: Mark Chappell <None> Reviewed-by: GomathiselviS <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None>

ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) python3 labels Oct 20, 2022

GomathiselviS added the jira label Nov 4, 2022

GomathiselviS self-assigned this Nov 4, 2022

ansibullbot removed the needs_triage label Nov 4, 2022

mandar242 mentioned this issue Nov 8, 2022

route53_health_check: Fix "Name" tag key removal idempotentcy issue #1253

Merged

ansibullbot added the has_pr label Nov 8, 2022

softwarefactory-project-zuul bot closed this as completed in #1253 Nov 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

route53_health_check - Name tag lost on 2nd deploy #1188

route53_health_check - Name tag lost on 2nd deploy #1188

anjo-swe commented Oct 20, 2022

ansibullbot commented Oct 20, 2022

ansibullbot commented Oct 20, 2022

mandar242 commented Nov 8, 2022

route53_health_check - Name tag lost on 2nd deploy #1188

route53_health_check - Name tag lost on 2nd deploy #1188

Comments

anjo-swe commented Oct 20, 2022

Summary

Issue Type

Component Name

Ansible Version

Collection Versions

AWS SDK versions

Configuration

OS / Environment

Steps to Reproduce

Expected Results

Actual Results

Code of Conduct

ansibullbot commented Oct 20, 2022

ansibullbot commented Oct 20, 2022

mandar242 commented Nov 8, 2022