-
Notifications
You must be signed in to change notification settings - Fork 336
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[PR #1933/b6b27bb0 backport][stable-7] Various IAM module cleanup This is a backport of PR #1933 as merged into main (b6b27bb). SUMMARY Consistently use "path" and "name" for IAM modules (with "path_prefix", "prefix" and "TYPE_name" as aliases) Consistently use "path_prefix" and "name" for IAM info modules (with "path", "prefix" and "TYPE_name" as aliases) Consistently test "path" and "name" for validity Spit out warning when we would update path, but it's not supported by the APIs (could become an error at a later date) Do not set "/" as the explicit default for paths ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/iam.py plugins/modules/iam_group.py plugins/modules/iam_instance_profile.py plugins/modules/iam_managed_policy.py plugins/modules/iam_role.py plugins/modules/iam_role_info.py plugins/modules/iam_user.py plugins/modules/iam_user_info.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
- Loading branch information
1 parent
f1da7ef
commit fdce1c9
Showing
14 changed files
with
324 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
minor_changes: | ||
- iam_group - ``group_name`` has been added as an alias to ``name`` for consistency with other IAM modules (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_group - Basic testing of ``name`` and ``path`` has been added to improve error messages (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
|
||
- iam_instance_profile - the ``prefix`` parameter has been renamed ``path`` for consistency with other IAM modules, ``prefix`` remains as an alias. | ||
No change to playbooks is required (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_instance_profile - Basic testing of ``name`` and ``path`` has been added to improve error messages (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_instance_profile - the default value for ``path`` has been removed. New instances will still be created with a default path of ``/``. | ||
No change to playbooks is required (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_instance_profile - attempting to change the ``path`` for an existing profile will now generate a warning, previously this was silently ignored (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_instance_profile - Basic testing of ``name`` and ``path`` has been added to improve error messages (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
|
||
- iam_managed_policy - the ``policy_name`` parameter has been renamed ``name`` for consistency with other IAM modules, ``policy_name`` remains as an alias. | ||
No change to playbooks is required (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_managed_policy - the ``policy_description`` parameter has been renamed ``description`` for consistency with other IAM modules, ``policy_description`` remains as an alias. | ||
No change to playbooks is required (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_managed_policy - Basic testing of ``name`` and ``path`` has been added to improve error messages (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
|
||
- iam_role_info - ``path`` and ``prefix`` have been added as aliases to ``path_prefix`` for consistency with other IAM modules (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
|
||
- iam_role - ``role_name`` has been added as an alias to ``name`` for consistency with other IAM modules (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_role - ``prefix`` and ``path_prefix`` have been added as aliases to ``path`` for consistency with other IAM modules (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_role - the default value for ``path`` has been removed. New roles will still be created with a default path of ``/``. | ||
No change to playbooks is required (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_role - attempting to change the ``path`` for an existing profile will now generate a warning, previously this was silently ignored (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_role - Basic testing of ``name`` and ``path`` has been added to improve error messages (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
|
||
- iam_user_info - the ``path`` parameter has been renamed ``path_prefix`` for consistency with other IAM modules, ``path`` remains as an alias. | ||
No change to playbooks is required (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_user_info - ``prefix`` has been added as an alias to ``path_prefix`` for consistency with other IAM modules (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
|
||
- iam_user - ``user_name`` has been added as an alias to ``name`` for consistency with other IAM modules (https://github.com/ansible-collections/amazon.aws/pull/1933). | ||
- iam_user - Basic testing of ``name`` and ``path`` has been added to improve error messages (https://github.com/ansible-collections/amazon.aws/pull/1933). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.