New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: instanced spell extension #358

Merged

anoyetta merged 1 commit into anoyetta:master from arthur-conde:u-s/develop

Jan 24, 2022

Contributor

arthur-conde commented Jan 24, 2022

This PR aims to fix bug in #306.

The issue is the list passed into MatchCore never contains instanced spells. These are stored separately in SpellTable.

Because instanced spells never update their parent's MatchDateTime, this branch of code is never entered.
Lookup the instanced spell from the table the same way it's done in the earlier branch


          fix: instanced spell extension

a893eef

Owner

anoyetta commented Jan 24, 2022

thx!

anoyetta merged commit a0c1d74 into anoyetta:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet