Skip to content

feat(extmarks): add clickable handlers for text buffers - #810

Closed
tobwen wants to merge 1 commit into
anomalyco:mainfrom
tobwen:feature/clickable-extmarks
Closed

feat(extmarks): add clickable handlers for text buffers#810
tobwen wants to merge 1 commit into
anomalyco:mainfrom
tobwen:feature/clickable-extmarks

Conversation

@tobwen

@tobwen tobwen commented Mar 12, 2026

Copy link
Copy Markdown

Summary

Adds a new clickable text-extmark feature for text buffers. Closes #809

This enables downstream interactions such as expand/edit/collapse summaries, preserves click targeting from mousedown, ignores drag-selection for click dispatch, and keeps typeId indexing correct during updates.

Verification

  • added targeted tests for typeId update handling and the drag-selection click regression
  • bun run build:lib passes
  • bun test src/lib/extmarks.test.ts src/renderables/__tests__/Textarea.selection.test.ts segfaults on local Bun 1.3.10

@simonklee

Copy link
Copy Markdown
Member

This pull request does not safely implement clickable text marks. Normal clicks
do not run their handlers, and clicks can run a handler for different text. It
also conflicts with the current main branch. Keeping #809 open.

@simonklee simonklee closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HAS PR] feat: clickable text extmarks for expand/collapse interactions

2 participants