Skip to content

fix(sdk): improve JSON parsing error handling with contextual messages #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Skeptomenos wants to merge 1 commit into
base: dev
Choose a base branch
from
+64 −2
Open

fix(sdk): improve JSON parsing error handling with contextual messages #7618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion packages/sdk/js/src/gen/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,41 @@ export const createClient = (config: Config = {}): Client => {
case "arrayBuffer":
case "blob":
case "formData":
case "json":
case "text":
data = await response[parseAs]()
break
case "json":
try {
data = await response.json()
} catch (parseError) {
// Handle JSON parsing errors with more context
const errorMessage = parseError instanceof Error ? parseError.message : String(parseError)
const enhancedError = new Error(
`Failed to parse JSON response: ${errorMessage}. ` +
`Status: ${response.status}, URL: ${response.url}`
)
;(enhancedError as any).cause = parseError
;(enhancedError as any).response = response

let finalError: unknown = enhancedError
for (const fn of interceptors.error._fns) {
if (fn) {
finalError = await fn(enhancedError, response, request, opts)
}
}

if (opts.throwOnError) {
throw finalError
}

return opts.responseStyle === "data"
? undefined
: {
error: finalError,
...result,
}
}
break
case "stream":
return opts.responseStyle === "data"
? response.body
Expand Down
33 changes: 32 additions & 1 deletion packages/sdk/js/src/v2/gen/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,41 @@ export const createClient = (config: Config = {}): Client => {
case "arrayBuffer":
case "blob":
case "formData":
case "json":
case "text":
data = await response[parseAs]()
break
case "json":
try {
data = await response.json()
} catch (parseError) {
// Handle JSON parsing errors with more context
const errorMessage = parseError instanceof Error ? parseError.message : String(parseError)
const enhancedError = new Error(
`Failed to parse JSON response: ${errorMessage}. ` +
`Status: ${response.status}, URL: ${response.url}`
)
;(enhancedError as any).cause = parseError
;(enhancedError as any).response = response

let finalError: unknown = enhancedError
for (const fn of interceptors.error.fns) {
if (fn) {
finalError = await fn(enhancedError, response, request, opts)
}
}

if (opts.throwOnError) {
throw finalError
}

return opts.responseStyle === "data"
? undefined
: {
error: finalError,
...result,
}
}
break
case "stream":
return opts.responseStyle === "data"
? response.body
Expand Down