Skip to content

Desktop: Fix Paste image on empty input #7130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdotdevin merged 5 commits into from
Jan 7, 2026
Merged

Desktop: Fix Paste image on empty input #7130

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26b9d2f
Desktop: Fix Paste image on empty input
dbpolito Jan 6, 2026
193df0c
Tweak
dbpolito Jan 6, 2026
025b5dc
Fix isFocused
dbpolito Jan 7, 2026
64b334f
Fix
dbpolito Jan 7, 2026
4509e79
Merge branch 'dev' of github.com:sst/opencode into fix_paste_image_em…
dbpolito Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/app/src/components/prompt-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,25 +288,23 @@ export const PromptInput: Component<PromptInputProps> = (props) => {
}

const handlePaste = async (event: ClipboardEvent) => {
if (!isFocused()) return

@adamdotdevin adamdotdevin Jan 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this? this was added because of conflicts between the terminal component and the prompt input, does removing it not cause any issues there?

@dbpolito dbpolito Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the event is on the this div, the terminal is on a completely different component, maybe when this was added it was checking listening to document paste before?

i tested pasting on terminal and on prompt, seems to be working fine...

@dbpolito dbpolito Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and for some reason, adding back this makes the issue come back... so this is somehow acting up....

doing further debugging on this isFocused, it's very buggy right now, sometimes even focusing the input, typing, and pasting, this is still false... very weird

const clipboardData = event.clipboardData
if (!clipboardData) return

event.preventDefault()
event.stopPropagation()

const items = Array.from(clipboardData.items)
const imageItems = items.filter((item) => ACCEPTED_FILE_TYPES.includes(item.type))

if (imageItems.length > 0) {
event.preventDefault()
event.stopPropagation()
for (const item of imageItems) {
const file = item.getAsFile()
if (file) await addImageAttachment(file)
}
return
}

event.preventDefault()
event.stopPropagation()
const plainText = clipboardData.getData("text/plain") ?? ""
addPart({ type: "text", content: plainText, start: 0, end: 0 })
}
Expand Down Expand Up @@ -347,13 +345,11 @@ export const PromptInput: Component<PromptInputProps> = (props) => {
}

onMount(() => {
editorRef.addEventListener("paste", handlePaste)
document.addEventListener("dragover", handleGlobalDragOver)
document.addEventListener("dragleave", handleGlobalDragLeave)
document.addEventListener("drop", handleGlobalDrop)
})
onCleanup(() => {
editorRef.removeEventListener("paste", handlePaste)
document.removeEventListener("dragover", handleGlobalDragOver)
document.removeEventListener("dragleave", handleGlobalDragLeave)
document.removeEventListener("drop", handleGlobalDrop)
Expand Down Expand Up @@ -1508,6 +1504,7 @@ export const PromptInput: Component<PromptInputProps> = (props) => {
}}
contenteditable="true"
onInput={handleInput}
onPaste={handlePaste}
onCompositionStart={() => setComposing(true)}
onCompositionEnd={() => setComposing(false)}
onKeyDown={handleKeyDown}
Expand Down