Skip to content

fix(core): default Vertex location to global #53872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 1 commit into from
Oct 8, 2026
Merged

fix(core): default Vertex location to global #53872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ai/src/providers/google-vertex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const configuredRoute = (input: Config, modelID: string | ModelID) => {
provider: id,
message: "Google Vertex tuned models do not support Express Mode API keys",
})
const location = GoogleVertexShared.location(inputLocation, "us-central1")
const location = GoogleVertexShared.location(inputLocation, "global")
const project = GoogleVertexShared.project(inputProject)
const endpoint =
baseURL ??
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/plugin/provider/google-vertex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function resolveLocation(options: Record<string, any>) {
process.env.GOOGLE_VERTEX_LOCATION ??
process.env.GOOGLE_CLOUD_LOCATION ??
process.env.VERTEX_LOCATION ??
"us-central1"
"global"
)
}

Expand Down
4 changes: 2 additions & 2 deletions packages/core/test/plugin/provider-google-vertex.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ describe("GoogleVertexPlugin", () => {
}),
)

it.effect("defaults location to us-central1 when only project is configured", () =>
it.effect("defaults location to global when only project is configured", () =>
withEnv(
{
GOOGLE_CLOUD_PROJECT: undefined,
Expand All @@ -299,7 +299,7 @@ describe("GoogleVertexPlugin", () => {
yield* addPlugin()
const provider = required(yield* catalog.get(Provider.ID.make("google-vertex")))
expect(provider.settings?.project).toBe("config-project")
expect(provider.settings?.location).toBe("us-central1")
expect(provider.settings?.location).toBe("global")
}),
),
)
Expand Down
Loading