Repository navigation
fix(core): broadcast wellknown updates globally and bound HTTP timeouts - #53821
Merged
Merged
Conversation
kitlangton
force-pushed
the
wellknown-config-cache
branch
from
October 9, 2026 22:03
e9f5efe to
c25bbc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WellKnownis a global service shared across all projectLocations, and #53667 (f108fa4928) now persists its manifest and remote config inKVacross transient refresh failures. Two gaps remain:WellKnown.refresh,WellKnown.add, andWellKnown.removepublishWellKnown.Event.Updatedwithout{ global: true }, so only theLocationthat triggered the update reloads while other openLocations remain on the previous manifest.WellKnown.inspectandWellKnown.resolveEntryhave no request deadline, so a hung socket during a VPN/WARP cutover holdsWellKnown's lock andConfig's reload lock until the OS socket timeout (up to 6 minutes) before falling back to the cachedKVsnapshot.What Changes
WellKnown.Event.Updatedwith{ global: true }inrefresh,add, andremoveso every openLocationreloads when a well-known source changes.Effect.timeout("15 seconds")) toWellKnown.inspectandWellKnown.resolveEntryso hung connections fall back promptly to the cachedKVconfig.Verification