Repository navigation
fix(tui): stop dialogs reading stale transcript rows after resync - #53800
Merged
Merged
Conversation
Dialogs opened from transcript rows outlive those rows. A reconnect resync keeps only the newest message page, so the Message Actions and execute dialogs read a row's narrowed Show accessor after its condition went false and crashed with "Stale read from <Show>". Capture the message ID and tool part when the dialog opens instead. Fixes #53740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialogs opened from transcript rows outlive those rows. A reconnect resync keeps only the newest message page, so the Message Actions and execute dialogs read a row's narrowed Show accessor after its condition went false and crashed with "Stale read from ". Capture the message ID and tool part when the dialog opens instead.
Fixes #53740