Repository navigation
feat(core): connect Azure through the Azure CLI as an external credential - #53794
Merged
Merged
Conversation
2 of 6 tasks
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes # (none, follow-up to #53626)
Type of change
What does this PR do?
Moves Azure's Azure CLI sign-in to the
externalcredential type that Bedrock now uses, and lets you pick the resource from a list instead of typing it in.azis on PATH and the CLI profile (azureProfile.json) shows a signed-in account. The lookup is one Resource Graph query across all subscriptions. If it finds nothing or fails, the field is a plain text input. A resource created after startup won't be listed until restart, but you can type its name.azeach time.oauth/azure-clicredentials intoexternalones that keep their resource, so nobody has to reconnect and plugin startup doesn't scan credentials.model-resolver.ts. The package checks its credential before thehttp.requesthook runs, so an external credential with no key failed withMissingCredentialErrorbefore the Azure plugin could add the bearer token. Azure now gets a placeholder key that the hook replaces. This sits next to Bedrock'ssigv4special case, so they can be cleaned up together.paddingLeftwas on a<text>, which ignores it). They're now wrapped in a box, like the session form does. This also fixes the Bedrock profile picker.How did you verify your code works?
bun typecheckinpackages/coreandpackages/tui, plusbun run testinpackages/core. The only failures are the existing shell-tool tests, which also fail onv2.bun dev, signed in with a real account, at 112 and 60 columns.Screenshots / recordings
Checklist