Repository navigation
fix(app): focus session search when the Home shortcut opens Home - #53761
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pressing the Home shortcut (Cmd+B, or Alt+Home on Windows) from a session opens Home, but nothing takes focus. The previously focused composer unmounts, focus falls back to the document body, and typing does nothing. Cmd+F was the only way to reach Search sessions.
Change
home.togglecommand records a one-shot request in the layout context when it navigates to Home.Testing
e2e/regression/home.spec.ts): from a session with the composer focused, Cmd/Ctrl+B focuses session search, typing filters to the matching session, the shortcut returns to the session, and clicking the Home button leaves the search unfocused. Verified it fails onv2without the fix (search not focused).home.spec.ts,settings-search.spec.ts, andtabs.spec.tspass locally (chromium).bun run typecheckinpackages/apppasses; Prettier is clean.Requested by: @Brendonovich (Brendan via Slack)