Skip to content

fix(ui): support inline custom answers for string choice fields in connect - #53625

Merged
rekram1-node merged 1 commit into
v2from
form-fixes
Oct 7, 2026
Merged

rekram1-node merged 1 commit into
v2from
form-fixes

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Web/desktop /connect, string field with options + custom: true:

 <AuthFormView>
-  <List>                         custom ignored, no way to type a value
-    GitHub.com
-    GitHub Enterprise
+  <RadioGroup>
+    ( ) GitHub.com
+    ( ) GitHub Enterprise
+    (•) Type your own answer
+        [ inline TextField ]
+  </RadioGroup>
+  [Continue]                     disabled until chosen or typed

TUI /connect, same field:

 selectAnswer
-  DialogSelect → "Type your own answer" → second DialogPrompt popup
+  StringChoiceField
+    1. GitHub.com
+    2. GitHub Enterprise
+    3. [inline editor]           esc → back to options

Base automatically changed from external-credentials to v2 October 7, 2026 00:55
@rekram1-node
rekram1-node force-pushed the form-fixes branch 2 times, most recently from e9e4999 to 0feb0b0 Compare October 7, 2026 01:30
@rekram1-node rekram1-node changed the title feat(integration): improve connection forms and setup fix(ui): support inline custom answers for string choice fields in connect Oct 7, 2026
@rekram1-node
rekram1-node force-pushed the form-fixes branch 2 times, most recently from c59bb3b to f581b2a Compare October 7, 2026 01:49
@rekram1-node
rekram1-node merged commit 1d610f9 into v2 Oct 7, 2026
13 checks passed
@rekram1-node
rekram1-node deleted the form-fixes branch October 7, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant