Repository navigation
fix(core): drop tool name and namespace length caps - #53586
Merged
Merged
Conversation
2 of 6 tasks
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53400
Tool registration capped normalized tool names at 128 characters and each namespace segment at 64. MCP server names become namespaces without shortening, so a server name over 64 characters had every tool skipped while the server still reported
connected.This drops both length caps. The character-class check and the non-empty requirement (including empty dotted namespace segments) stay in place.
Removed the tests that only asserted the length caps.
Verification (
packages/core):bun test test/tool-registry.test.ts test/mcp.test.ts,bun typecheck.Requested by: @rekram1-node (Aiden Cline via Slack)