Repository navigation
feat(core): stop asking for external directory access by default - #53585
Merged
Merged
Conversation
2 of 6 tasks
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A
Type of change
What does this PR do?
Removes the
external_directory: * → askrule from the default agent ruleset inAgent.Info.default. The catch-all* → allownow covers paths outside the project too, so build/general/custom agents no longer prompt before touching them.Explore also stops asking: it keeps its deny-by-default tool list but now explicitly allows
external_directory.Cleanup of rules that the new default makes redundant:
Agentno longer appends the managedexternal_directoryallows (shell output, tool output, tmp, config) to every agent, and no longer depends onGlobal. User config rules are appended after these anyway, so they only ever applied when nothing else matched.external_directoryallow for the plan directory. Its edit restrictions (deny everywhere except the plan directory) are unchanged.The
.envread prompts stay as they are.How did you verify your code works?
packages/core/test/agent.test.tsthat an arbitrary outside path evaluates toallowfor the build and explore agents.Agent.Info.defaultinstead of a hard-coded copy of the old ruleset, and checks that outside directories are allowed.packages/core/test/config/agent.test.tsexpectations for the removed managed rules.bun testinpackages/core: all pass exceptisolates global home and XDG roots, which also fails onorigin/v2without this change.bun testinpackages/clipasses.bun run checkpasses.Screenshots / recordings
N/A
Checklist
— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊