Repository navigation
fix(tui): match execute dialog to two-toned dialog layout - #53584
Merged
Merged
Conversation
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DialogExecuteto the same title / raised-content / footer structure and theme tokens used by the existing two-toned dialogs (CommandViewindialog-integration.tsx,Answerinbtw.tsx,DialogWorkspaceFileChanges)<box gap={1} paddingBottom={1}>), footer trimmed topaddingLeft={2} paddingRight={2}, and the code scrollbox gainscontentOptions={{ minHeight: 0 }}like the other scrollable dialogsVerification
bun typecheckinpackages/tuipassesbun run dev:liveat wide and narrow sizes via a temporary storybook story (removed afterward); screenshots confirm the title area, raised content band, and footer match the other two-toned dialogs— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊