Skip to content

fix(tui): match execute dialog to two-toned dialog layout - #53584

Merged
thdxr merged 1 commit into
v2from
execute-dialog-tone
Oct 6, 2026
Merged

thdxr merged 1 commit into
v2from
execute-dialog-tone

Conversation

@thdxr

@thdxr thdxr commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Rework DialogExecute to the same title / raised-content / footer structure and theme tokens used by the existing two-toned dialogs (CommandView in dialog-integration.tsx, Answer in btw.tsx, DialogWorkspaceFileChanges)
  • Outer wrapper now carries the dialog padding (<box gap={1} paddingBottom={1}>), footer trimmed to paddingLeft={2} paddingRight={2}, and the code scrollbox gains contentOptions={{ minHeight: 0 }} like the other scrollable dialogs
  • Head of this: composes on the in-progress patch that wraps code/JSON by character, follows line gutters to wrapped rows, and puts the scrollable content on a raised background with its own padding

Verification

  • bun typecheck in packages/tui passes
  • Viewed in the live TUI via bun run dev:live at wide and narrow sizes via a temporary storybook story (removed afterward); screenshots confirm the title area, raised content band, and footer match the other two-toned dialogs

— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊

@thdxr
thdxr merged commit ccb5162 into v2 Oct 6, 2026
11 checks passed
@thdxr
thdxr deleted the execute-dialog-tone branch October 6, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant