Repository navigation
feat(app): keep each /btw answer in its own tab until closed - #53270
Merged
Merged
Conversation
Client slash commands such as /btw generate with the session's model, so the composer now applies its selection to the session first, following the same steer rule as server commands. Also clears the pre-existing lint in submit.ts so lint:changed passes.
In-flight side questions no longer abort when the user navigates away; the answer lands in the session's store when it arrives. Reload, closing the question's tab or disposing the extension still abandons it as retryable.
# Conflicts: # packages/app/src/composer/submit.test.ts # packages/app/src/composer/submit.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/btwquestion now opens its own side-panel tab instead of replacing the previous answer./btwstays one-shot: no follow-ups, reply history, or history/search view./btwanswers with the model selected in the composer: like sending a prompt, the composer applies its agent/model selection to the session before running the client command (skipped when queueing behind a running turn).Storage uses a declared
Store.sessionstore, so it follows the existing per-session layout lifetime and pruning. Answers still come from the existing generation-only API with the original instructions; nothing is added to the main session, and no persistence-layer or backend changes are made.Validation
/btwkeeper: 4 passed. Covers separate tabs, reload restore, close-deletes-and-stays-closed after reload, concurrent questions, interruption/retry, separate parent sessions, Home/remount, and twelve long-titled tabs at a narrow desktop width.v2(one tab instead of two) before the change.packages/appandpackages/gui-extensionstypechecks,lint:changed, formatting andgit diff --checkpassed.Validation limits: the root
bun run checkexceeded this Host's process-thread limit, and the extension-host Storybook suites timed out loading their iframe before any assertion. Native desktop was not exercised.Requested by: @Brendonovich (Brendan via Slack)