Repository navigation
feat(app): restore the session location missing prompt - #53268
Merged
Merged
Conversation
Keep the worktree list visible while it refreshes, and stop the directory picker from suspending the screen that opened it. Co-authored-by: OpeOginni <107570612+OpeOginni@users.noreply.github.com>
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Brings back the "Session location unavailable" prompt that #46695 removed. When a session's folder is gone, the timeline, docks and side panels still render, but the composer is replaced by a prompt to move the session:
Both call
session.move; the existingsession.movedhandling then swaps the composer back in.The prompt was removed because any failed location sync triggered it. It now appears only when
location.getreturns the typedLocationNotFoundError(404) for the session's own directory. 500s and other generic failures keep the composer and retry exactly as before; the existing cases insession-location-sync.spec.tscover that. A not-found answer isn't retried, since retrying can't succeed until the folder changes. Reconnecting or changing location clears the state and checks again.Frontend only. It uses
LocationNotFoundErrorfrom the current client and doesn't add the 403/permission-denied error.Also fixes two UI issues found while testing:
How did you verify your code works?
bun run typecheckinpackages/app.session-location-sync.spec.tskeeper: a 404LocationNotFoundErrorshows the prompt, keeps the history, removes the prompt textbox and makes only one location request; choosing an existing worktree postssession.move, and aftersession.movedthe composer comes back. I confirmed it fails without the source change, and all 9 cases in the suite pass with it.opencode serve: deleted a session's worktree, saw the prompt, then moved the session to another worktree and got the composer back.Requested by: @Brendonovich (Brendan via Slack)