Repository navigation
fix(session-ui): align provider error icon with first line - #52859
Merged
Merged
Conversation
Hona
force-pushed
the
error-icon-alignment
branch
from
October 6, 2026 02:44
a09a601 to
cb62309
Compare
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the provider error icon with the first line of the message instead of the middle of the whole block.
error-card.stories.tsxshows one short and one wrapped provider error. The component test checks that the icon center equals the first line's center in both errors, and that the long error wraps.Real app timeline (
setupTimelinee2e harness):Requested by: @iamdavidhill