feat(tui): paste primary selection on middle click - #44938
Closed
sshnaidm wants to merge 1 commit into
Closed
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate PRs FoundPR #32370: feat(tui): add linux_clipboard_selection config for primary buffer support
PR #6370: fix: enable primary clipboard copy for Wayland/X11 to fix Linux middle-click paste
PR #44443: feat(tui): add selection to prompt as quoted context
I recommend reviewing PR #32370 and #6370 to ensure PR #44938 doesn't duplicate existing work or conflicts with prior clipboard/selection implementations. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readPrimary()to the clipboard module (wl-paste → xclip → xsel fallback chain) and exposes it as an optionalreadPrimarymethod onClipboardServiceprompt.paste.primarycommand in the prompt and dispatches it from the app root on middle-button mouse down; copy-on-select mouse-up is skipped for middle button so it doesn't clobber the clipboardTest plan
bun testin packages/tui (new tests forreadPrimaryCommandfallbacks)bun typecheckin packages/tui