Skip to content

fix(provider): handle SSE reader cancel rejections #44912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexanderWillner wants to merge 2 commits into from
+3 −3
Closed

fix(provider): handle SSE reader cancel rejections #44912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
456eac5
fix(provider): catch SSE reader cancel rejection
AlexanderWillner Aug 25, 2026
70bf2f9
test(pty): raise exit-poll deadline to 20s
AlexanderWillner Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/aisdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function wrapSSE(res: Response, ms: number, ctl: AbortController) {
const id = setTimeout(() => {
const err = new Error("SSE read timed out")
ctl.abort(err)
void reader.cancel(err)
reader.cancel(err).catch(() => {})
reject(err)
}, ms)

Expand Down
2 changes: 1 addition & 1 deletion packages/opencode/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function wrapSSE(res: Response, ms: number, ctl: AbortController) {
const id = setTimeout(() => {
const err = new ProviderError.ResponseStreamError("SSE read timed out")
ctl.abort(err)
void reader.cancel(err)
reader.cancel(err).catch(() => {})
reject(err)
}, ms)

Expand Down
2 changes: 1 addition & 1 deletion packages/opencode/test/server/httpapi-v2-pty.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe("v2 pty HttpApi", () => {
expect(body.data.title).toBe("v2")

// The canonical surface keeps exited sessions observable with their exit code.
const deadline = Date.now() + 5_000
const deadline = Date.now() + 20_000
let info: { status: string; exitCode?: number } | undefined
while (Date.now() < deadline) {
const found = await request(`/api/pty/${body.data.id}`, tmp.path)
Expand Down
Loading