Skip to content

fix: Tool calling on windows #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 11 commits into from
Nov 12, 2025
Merged

fix: Tool calling on windows #4234

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
20aa417
fix: Tool calling on windows
Hona Nov 12, 2025
d2ef205
chore: Revert unrelated
Hona Nov 12, 2025
376d6a8
fix: Use atomic writes via temp + renames
Hona Nov 12, 2025
322b732
chore: Back to bun apis and clean
Hona Nov 12, 2025
5de9812
chore: Make it clearer what & why
Hona Nov 12, 2025
e05e7c3
chore: Claude review feedback
Hona Nov 12, 2025
63fa88b
fix: We don't need to do this stuff, await the json earlier fixed it
Hona Nov 12, 2025
6aa319e
chore: Remove things
Hona Nov 12, 2025
6f09f43
chore: less
Hona Nov 12, 2025
3b5af86
chore: We dont even need tmp files
Hona Nov 12, 2025
2601971
chore: Back to same style
Hona Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions packages/opencode/src/storage/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,26 @@ export namespace Storage {
const target = path.join(dir, ...key) + ".json"
return withErrorHandling(async () => {
using _ = await Lock.read(target)
return Bun.file(target).json() as Promise<T>
const result = await Bun.file(target).json()
return result as Promise<T>
Comment thread
Hona marked this conversation as resolved.
Outdated
})
}

export async function update<T>(key: string[], fn: (draft: T) => void) {
const dir = await state().then((x) => x.dir)
const target = path.join(dir, ...key) + ".json"
return withErrorHandling(async () => {
using _ = await Lock.write("storage")
using _ = await Lock.write(target)
const content = await Bun.file(target).json()
fn(content)
await Bun.write(target, JSON.stringify(content, null, 2))
const jsonContent = JSON.stringify(content, null, 2)

Copilot AI Nov 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file handle is opened without checking if the directory exists first. In the update function, unlike the write function (line 203), there's no fs.mkdir(path.dirname(target), { recursive: true }) call before opening the file. This could fail if the parent directories don't exist yet.

Suggested change
const jsonContent = JSON.stringify(content, null, 2)
const jsonContent = JSON.stringify(content, null, 2)
await fs.mkdir(path.dirname(target), { recursive: true })

Copilot uses AI. Check for mistakes.
const handle = await fs.open(target, "w")
try {
await handle.writeFile(jsonContent, "utf-8")
await handle.sync()
} finally {
await handle.close()
}
return content as T
})
}
Expand All @@ -190,8 +198,16 @@ export namespace Storage {
const dir = await state().then((x) => x.dir)
const target = path.join(dir, ...key) + ".json"
return withErrorHandling(async () => {
using _ = await Lock.write("storage")
await Bun.write(target, JSON.stringify(content, null, 2))
using _ = await Lock.write(target)
const jsonContent = JSON.stringify(content, null, 2)
await fs.mkdir(path.dirname(target), { recursive: true })
const handle = await fs.open(target, "w")
try {
await handle.writeFile(jsonContent, "utf-8")
await handle.sync()
} finally {
await handle.close()
}
})
}

Expand Down
Loading