fix(app): register archive session command in both layouts - #41741
Merged
Brendonovich merged 4 commits intoAug 21, 2026
Conversation
The session.archive command was registered inside LegacyLayout, which never mounts when general.newLayoutDesigns is enabled (the default). The keybind was dead and the command missing from the palette. Move it to use-session-commands, mounted by the session route in both shells, and extract the archive logic into a useSessionArchive hook shared with the timeline menus and deleteSession.
github-actions
Bot
added
the
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
Author
|
Happy to adjust anything, especially the |
Contributor
Author
|
@Brendonovich @Hona Hi guys, would you mind taking a look at this PR when you get a chance? It would make daily use of the Desktop version much easier by bringing back the Archive feature. Thanks a lot! |
Brendonovich
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41690
Type of change
What does this PR do?
session.archivewas registered insideLegacyLayout, which never mountssince
general.newLayoutDesignsdefaults totrue. So the keybind didnothing and the command was missing from the palette.
Moved it to
use-session-commands, which the session route mounts in bothshells. While doing that I pulled the archive logic out of
message-timeline.tsxinto auseSessionArchivehook, so the timelinemenus, the new command and
deleteSessionshare the same navigation codeinstead of duplicating it.
No behavior change for the
...menu.How did you verify your code works?
bun run --cwd packages/desktop dev, opened a session, pressedCmd+Shift+Backspace -> session archived
...menu still worksbun typecheckand thecommand/command-keybindtests passScreenshots / recordings
Before
"Archive session" missing from the command palette but works from the
...menu.After
"Archive session" shown and working from the command palette. Still working from the
...menu.Checklist