refactor(tui): remove redundant code - #40081
Merged
Merged
Conversation
kitlangton
force-pushed
the
tui-simplify
branch
from
August 1, 2026 18:08
fb2c34b to
780cfe9
Compare
github-actions Bot
pushed a commit
to ReStranger/opencode
that referenced
this pull request
Aug 3, 2026
![nix-auto-updates[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
* upstream/v2: test(core): stabilize shell integration timing (anomalyco#40084) fix(core): route Bedrock packages natively (anomalyco#40165) feat(ai): add native Bedrock Mantle support (anomalyco#40119) fix(tui): reserve home and end for navigation (anomalyco#40123) refactor(ai): align multimodal naming (anomalyco#40073) refactor(tui): remove redundant code (anomalyco#40081) fix(tui): discover plugins across config roots (anomalyco#39988) fix(tui): make vertical tabs responsive (anomalyco#40080) feat(tui): add vertical session tabs (anomalyco#40072) fix: preserve provider error status (anomalyco#39976) fix(tui): prevent sidebar scrollbar flash (anomalyco#40056) feat(tui): prioritize favorite model search results (anomalyco#40049)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove redundant V2 TUI code discovered during a broad simplification audit. The rendered UI and interaction behavior remain unchanged, while the sidebar scrollbar follow-up avoids touching a destroyed renderable if its deferred reset runs after unmount.
Before / After
Before
The sidebar queued a scrollbar visibility reset without checking whether the keyed session view had already unmounted. Several TUI paths also maintained duplicate derived memos, selection calculations, registrations, conditions, and unused declarations.
After
The deferred scrollbar reset safely no-ops after destruction. Existing shared selection helpers and derived values replace duplicate logic, and unreachable or unused code is removed.
How
scroll.isDestroyed.Scope
This is limited to behavior-preserving V2 TUI cleanup. It does not include the larger plugin lifecycle, diff viewer, theme, or mini TUI consolidations identified during the audit.
Testing
bun typecheckfrompackages/tuibun run testfrompackages/tui: 586 passed, 5 skipped, 0 failedgit diff --checkDemo
Not applicable: the refactor intentionally preserves settled TUI output and interactions.