Conversation
- Add 93 missing keys to packages/app zh.ts and 103 to zht.ts - Add 2 missing keys to console zh.ts and zht.ts - Add 6 missing keys to ui zh.ts and zht.ts - Fix common.continue mistranslation - Translate terminalFont settings that were left in English Closes #31660
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31660
Type of change
What does this PR do?
Fixes missing and incorrect Chinese translations across 3 packages (app, console, ui) for both Simplified Chinese (zh) and Traditional Chinese (zht).
Changes:
packages/app/src/i18n/zh.ts(WSL onboarding, settings, error messages, etc.)packages/app/src/i18n/zht.ts(same as above plus home page keys)packages/console/app/src/i18n/zh.tsandzht.ts(nav.go,common.contactUs)packages/ui/src/i18n/zh.tsandzht.ts(sessionReview/diffs keys)common.continuemistranslation: "提交" → "继续" (zh) / "繼續" (zht)terminalFontsettings that were left in EnglishHow did you verify your code works?
Wrote a Node.js script that extracts all keys from
en.tsand compares againstzh.ts/zht.tsin each package. Before fixes: 93/103/2/2/6/6 missing keys. After fixes: 0 missing keys across all packages.Screenshots / recordings
N/A - translation-only changes, no UI modifications.
Checklist