Skip to content

fix(desktop): respect proxy environment #25846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 3 commits into from
May 5, 2026
Merged

fix(desktop): respect proxy environment #25846

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38745bb
fix(desktop): respect proxy environment
Hona May 5, 2026
f7ce057
fix(desktop): apply proxy after shell env
Hona May 5, 2026
8b918de
chore(desktop): clarify proxy type cast
Hona May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/desktop/src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { randomUUID } from "node:crypto"
import { EventEmitter } from "node:events"
import { existsSync } from "node:fs"
import * as http from "node:http"
import { createServer } from "node:net"
import { homedir } from "node:os"
import { join } from "node:path"
Expand Down Expand Up @@ -77,6 +78,7 @@ setupApp()

function setupApp() {
ensureLoopbackNoProxy()
useEnvProxy()
app.commandLine.appendSwitch("proxy-bypass-list", "<-loopback>")
if (!app.isPackaged) app.commandLine.appendSwitch("remote-debugging-port", "9222")
Comment thread
Hona marked this conversation as resolved.

Expand Down Expand Up @@ -133,6 +135,15 @@ function useSystemCertificates() {
}
}

function useEnvProxy() {
try {
const setGlobalProxyFromEnv = (http as typeof http & { setGlobalProxyFromEnv: () => void }).setGlobalProxyFromEnv
setGlobalProxyFromEnv()
} catch (error) {
logger.warn("failed to load proxy environment", error)
}
}

function emitDeepLinks(urls: string[]) {
if (urls.length === 0) return
pendingDeepLinks.push(...urls)
Expand Down
Loading