Skip to content

fix(beta): PR resolvers/smoke check should typecheck all pacakges #23913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 2 commits into from
Apr 23, 2026
Merged

fix(beta): PR resolvers/smoke check should typecheck all pacakges #23913

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2b2b7
fix(beta): run typecheck at repo root for turborepo
Hona Apr 23, 2026
2c370f6
fix(beta): remove unnecessary backtick escapes
Hona Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions script/beta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ async function typecheck() {
console.log(" Running typecheck...")

try {
await $`bun typecheck`.cwd("packages/opencode")
await $`bun typecheck`
return true
} catch (err) {
console.log(`Typecheck failed: ${err}`)
Expand Down Expand Up @@ -113,7 +113,7 @@ async function fix(pr: PR, files: string[], prs: PR[], applied: number[], idx: n
"If bun.lock is conflicted, do not hand-merge it. Delete bun.lock and run bun install after the code conflicts are resolved.",
"If a PR already deleted a file/directory, do not re-add it, instead apply changes in the new semantic location.",
"If a PR already changed an import, keep that change.",
"After resolving the conflicts, run `bun typecheck` in `packages/opencode`.",
"After resolving the conflicts, run \`bun typecheck\` at the repo root.",

Copilot AI Apr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These backslashes will be included literally in the prompt string (e.g., it will print "`bun typecheck`") since backticks don’t need escaping inside double-quoted TS strings. Remove the backslashes so the prompt renders as intended.

Suggested change
"After resolving the conflicts, run \`bun typecheck\` at the repo root.",
"After resolving the conflicts, run `bun typecheck` at the repo root.",

Copilot uses AI. Check for mistakes.
"If typecheck fails, you may also update any files reported by typecheck.",
"Keep any non-conflict edits narrowly scoped to restoring a valid merged state for the current PR batch.",
"Fix any merge-caused typecheck errors before finishing.",
Expand Down Expand Up @@ -149,8 +149,8 @@ async function smoke(prs: PR[], applied: number[]) {
const prompt = [
"The beta merge batch is complete.",
`Merged PRs on HEAD:\n${done}`,
"Run `bun typecheck` in `packages/opencode`.",
"Run `./script/build.ts --single` in `packages/opencode`.",
"Run \`bun typecheck\` at the repo root.",
"Run \`./script/build.ts --single\` in \`packages/opencode\`.",

Copilot AI Apr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompt strings escape backticks with backslashes ("`...") which will show up literally in the output. Backticks don’t need escaping in normal TS strings; drop the backslashes so the instructions render cleanly.

Suggested change
"Run \`bun typecheck\` at the repo root.",
"Run \`./script/build.ts --single\` in \`packages/opencode\`.",
"Run `bun typecheck` at the repo root.",
"Run `./script/build.ts --single` in `packages/opencode`.",

Copilot uses AI. Check for mistakes.
"Fix any merge-caused issues until both commands pass.",
"Do not create a commit.",
].join("\n")
Expand Down
Loading